From nobody Wed Jun 17 18:23:56 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ggXLN5yqwz6hJKJ for ; Wed, 17 Jun 2026 18:23:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ggXLN27HXz3kLW for ; Wed, 17 Jun 2026 18:23:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781720636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yDbhbDUGAxRaj60GQFLhZflZNgh3qFj/NgSbImoyxxk=; b=toe68GKISmpBpHXNR/jtnbjzZy5/s7TJ6AjRNnHdcmVcW1eTqcxzK6sJB0TSrTjNmCicIu jI5jTWmH4UrupCLEDrdoHupRZDpSfIyhIyZZfk+Q/mC9K7+km7bfaolrVX504OFXkYzy01 pZYjdOifmHpF6TXkOzqpRD+f/wqytwD3Gu/JqbtsV5Nmab7FlrW0aH3lqDYFoTxnP28d81 ZJVzgdllYkDPaugCL3DbFnCC/uvb5Hr82xl/2AhQbETPsR+Iydtv0JhjP9UakKlG9HuEl7 +6tpZjQE8u2MhE303+ez0NjinIZRVIu8qeRWIjNLekPwqgoDQ2xFDQrqp4v1ZQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781720636; a=rsa-sha256; cv=none; b=tcLZU060nDok+LR/ESoFlAWHJDHUxXul8bZTtqrmriqksoS78YO/L5WXFbMBAe6x18VbjH bwlsg4723qVDcd+XoIWaYoKtoEdGvc855WVKmDJFQANN1auCWVEts8PR17Udm+9rOyoLeW AvUiMvCDPLmb6cPnV7W6hFNe61P8s6v8txr30TXY4ilk8fhCtfWDT6qsXUtbri3cqnpHEI EafVjpCPjL38lcACXDhmjjtTK3YKlCDNCXvPvCxwwmSvhUBjwNFQ98WSDGH8rdxP0/d3OP oNEU/4+hF2Geb/hHI5aSFjFkOTxCD2KkAwOnJtybi+E2ZzKlZXQ+5r0aAXvxFA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781720636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yDbhbDUGAxRaj60GQFLhZflZNgh3qFj/NgSbImoyxxk=; b=HVJpnZea8leus8eNtpZ1pWbvvT88+0JJOY/KbMI40I+yQZpLx6+Mj7j6Wg9zbMhcQkSzIZ eLhkgVRnclbG46Y+MSj/y3pe8qCfzvt48MVIfWZ/pRg5TNPUNNZZvpNQcWBEonr0+4xtgs tSb1dnyycZK7uhgxozt6JIu1nFgd+5Rq8kGF/c1gs/puarIh7SsyNAh9TvZUqERFMWp/S2 GRLxuM7+QBb5h2zPPdClQ5MMXh1JDAPsm+pvKcUepqUcsLMPE+l470XGPPpfhuAcMDxHz7 5v6qhJpa/OuxcUbI+pMxVP623OxBQDSw0eJLYmL7AMaYtRCtJ2qjaJP13WUD2Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4ggXLN1gYgz7gp for ; Wed, 17 Jun 2026 18:23:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24615 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 17 Jun 2026 18:23:56 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Slava Shwartsman From: Konstantin Belousov Subject: git: 17cf7760a98a - main - mlx5en: guard against empty eth_proto_oper mask List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 17cf7760a98a87c33d0415e2d2e1d4b24dd69e4d Auto-Submitted: auto-generated Date: Wed, 17 Jun 2026 18:23:56 +0000 Message-Id: <6a32e63c.24615.41d6a4d0@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=17cf7760a98a87c33d0415e2d2e1d4b24dd69e4d commit 17cf7760a98a87c33d0415e2d2e1d4b24dd69e4d Author: Slava Shwartsman AuthorDate: 2026-06-10 16:43:08 +0000 Commit: Konstantin Belousov CommitDate: 2026-06-17 18:23:15 +0000 mlx5en: guard against empty eth_proto_oper mask eth_proto_oper is used to derive the active media mode, but an empty mask leaves no valid bit for ilog2() to consume. Treat this as an invalid carrier update, reset the active media state, and report the unexpected PTYS value. Reviewed by: kib Tested by: Wafa Hamzah MFC after: 1 week Sponsored by: NVIDIA Networking --- sys/dev/mlx5/mlx5_en/mlx5_en_main.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c index 35450776e54e..6d8e1ba41709 100644 --- a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c +++ b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c @@ -445,9 +445,16 @@ mlx5e_update_carrier(struct mlx5e_priv *priv) ext = MLX5_CAP_PCAM_FEATURE(mdev, ptys_extended_ethernet); eth_proto_oper = MLX5_GET_ETH_PROTO(ptys_reg, out, ext, eth_proto_oper); + if (eth_proto_oper == 0) { + priv->media_active_last = IFM_ETHER; + if_setbaudrate(priv->ifp, 1); + mlx5_en_err(priv->ifp, "eth_proto_oper is 0\n"); + return; + } connector_type = MLX5_GET(ptys_reg, out, connector_type); if (connector_type >= MLX5E_CONNECTOR_TYPE_NUMBER) connector_type = MLX5E_PORT_UNKNOWN; + i = ilog2(eth_proto_oper); if (ext) {