From owner-svn-ports-all@FreeBSD.ORG  Sun Oct 28 12:17:54 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id B9CE6108;
 Sun, 28 Oct 2012 12:17:54 +0000 (UTC)
 (envelope-from utisoft@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
 [209.85.214.54])
 by mx1.freebsd.org (Postfix) with ESMTP id B56538FC0A;
 Sun, 28 Oct 2012 12:17:53 +0000 (UTC)
Received: by mail-bk0-f54.google.com with SMTP id jf20so1719942bkc.13
 for <multiple recipients>; Sun, 28 Oct 2012 05:17:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date
 :x-google-sender-auth:message-id:subject:to:cc:content-type;
 bh=m8Ua330WPkPc/nL5XyYVj6pJBB1Pljuk7chq/1wEetM=;
 b=qz53u7SuICxbvJu8MTSoOJ1UNwIJqjupXSS9MKRQV2/ffNQE3pD4qqzaY0EX628qu0
 6BhKpb8YQNduQqv1sv09Vt0KgrjOAzyrPLyTpK84aE4eDGIAluHT0Q9kS/LoebSD5HHD
 d2RAZAd1qCCB/qvCV1Zp5vza0EjCAnmjblHH9TWq6Yhs3ssFdLaBIKAYhInlWw6OZ+PE
 0FBUfeOrWb5aZYKCBa14JxuDwkCDrg1JFjzZv+WYV6Ng310U+VCsWHRdOPmkGbCQO1qk
 vXl9fqIvfXSkXKP36WJsqHaRMSA25jtoU6LHenuAxHcI50TG1FoFnNJp2DlNHNKEC9Md
 dY0g==
Received: by 10.204.11.207 with SMTP id u15mr8574060bku.40.1351426672562; Sun,
 28 Oct 2012 05:17:52 -0700 (PDT)
MIME-Version: 1.0
Sender: utisoft@gmail.com
Received: by 10.204.50.197 with HTTP; Sun, 28 Oct 2012 05:17:22 -0700 (PDT)
In-Reply-To: <201210222013.q9MKDbWx096398@svn.freebsd.org>
References: <201210222013.q9MKDbWx096398@svn.freebsd.org>
From: Chris Rees <crees@FreeBSD.org>
Date: Sun, 28 Oct 2012 12:17:22 +0000
X-Google-Sender-Auth: Mm3_dCmUDFb11xHDZZRSN5P1Sss
Message-ID: <CADLo838WrY0Tz-r1xf_PE0p5dYiyZGO0kZnJM_tqWPWGwpABVQ@mail.gmail.com>
Subject: Re: svn commit: r306286 - in head/sysutils/uhidd: . files
To: Guido Falsi <madpilot@freebsd.org>, kaiwang27@gmail.com
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Oct 2012 12:17:54 -0000

On 22 October 2012 21:13, Guido Falsi <madpilot@freebsd.org> wrote:
> XXX Ports RC script present
> XXX Ports RC script present
> Author: madpilot
> Date: Mon Oct 22 20:13:36 2012
> New Revision: 306286
> URL: http://svn.freebsd.org/changeset/ports/306286
>
> Log:
>   - Update to 0.2.1

<snip>

> Modified: head/sysutils/uhidd/files/uhidd.in
> ==============================================================================
> --- head/sysutils/uhidd/files/uhidd.in  Mon Oct 22 20:06:34 2012        (r306285)
> +++ head/sysutils/uhidd/files/uhidd.in  Mon Oct 22 20:13:36 2012        (r306286)
> @@ -19,7 +19,7 @@ name="uhidd"
>  rcvar=uhidd_enable
>  command="%%PREFIX%%/sbin/${name}"
>  start_cmd="uhidd_start"
> -required_modules="uvhid vkbd"
> +required_modules="vkbd"
>  pidprefix="/var/run/uhidd"
>
>  load_rc_config $name
>

I remember when I fixed the ${name}_enable default missing case here,
and looking again I had missed out a colon :)

This patch fixes that, and contains other style fixes, but most
importantly it replaces a use of [ with a much faster variable
substitution.

http://www.bayofrum.net/~crees/patches/uhidd-rc.diff

Kai Wang, is it OK?

Chris