Date: Thu, 3 Oct 2019 18:57:21 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: Warner Losh <imp@bsdimp.com>, Sebastian Huber <sebastian.huber@embedded-brains.de>, Bruce Evans <brde@optusnet.com.au>, FreeBSD <freebsd-hackers@freebsd.org> Subject: Re: Why is tc_get_timecount() called two times in tc_init()? Message-ID: <20191003155721.GP44691@kib.kiev.ua> In-Reply-To: <47834.1570116246@critter.freebsd.dk> References: <0e27fb3e-0f60-68e1-dbba-f17c3d91c332@embedded-brains.de> <20191002140040.GA44691@kib.kiev.ua> <20191003013314.O2151@besplex.bde.org> <20191002163946.GE44691@kib.kiev.ua> <20191003030837.C2787@besplex.bde.org> <20191003084021.GI44691@kib.kiev.ua> <CANCZdfpcOBJiYAKafhiWZS2g4vnLGVvzqhaOXetSSnU2Hj91nw@mail.gmail.com> <47834.1570116246@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 03, 2019 at 03:24:06PM +0000, Poul-Henning Kamp wrote: > -------- > In message <CANCZdfpcOBJiYAKafhiWZS2g4vnLGVvzqhaOXetSSnU2Hj91nw@mail.gmail.com> > , Warner Losh writes: > > >I think this is a good fix. I recall phk saying it was more paranoia for > >edge cases than really needed in a private email to me, but it's in the > >'gap' of email that I lost in a disk crash 12 years ago so I can't find it > >for sure. > > I think the original reason for this was (locked) delta-based > timecounters, (ie counters which roll over rapidly) in order that > their first "real" use would not return truly bogus values. So do you think it makes sense to keep the doubled call at init ? Or it did not played out and I should commit my patch.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191003155721.GP44691>