From owner-p4-projects@FreeBSD.ORG  Tue Sep 30 20:34:16 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D345316A4C0; Tue, 30 Sep 2003 20:34:15 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ACF8316A4B3
	for <perforce@freebsd.org>; Tue, 30 Sep 2003 20:34:15 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 38CC743FF9
	for <perforce@freebsd.org>; Tue, 30 Sep 2003 20:34:15 -0700 (PDT)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id h913YFXJ051110
	for <perforce@freebsd.org>; Tue, 30 Sep 2003 20:34:15 -0700 (PDT)
	(envelope-from imp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.9/8.12.9/Submit) id h913YEnh051107
	for perforce@freebsd.org; Tue, 30 Sep 2003 20:34:14 -0700 (PDT)
	(envelope-from imp@freebsd.org)
Message-Id: <200310010334.h913YEnh051107@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	imp@freebsd.org using -f
From: Warner Losh <imp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 38944 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
Date: Wed, 01 Oct 2003 03:34:16 -0000
X-Original-Date: Tue, 30 Sep 2003 20:34:14 -0700 (PDT)
X-List-Received-Date: Wed, 01 Oct 2003 03:34:16 -0000

http://perforce.freebsd.org/chv.cgi?CH=38944

Change 38944 by imp@imp_koguchi on 2003/09/30 20:34:04

	cv_wait usually loops, per rwatson.

Affected files ...

.. //depot/doc/strawman-driver.c#6 edit

Differences ...

==== //depot/doc/strawman-driver.c#6 (text+ko) ====

@@ -23,17 +23,24 @@
 		return EGONE;
 	if (sc->dead)				/* RACE #1, a */
 		return EGONE;
-...
+	switch (cmd) 
+	{
 	case FOO_GERBIL:
 		/*
 		 * Wait for a weird GERBIL event in the device and return it
 		 */
 		mtx_lock(&sc->mtx);
-		cv_wait(&sc->cv, &sc->mtx);
+		sc->sc_gerbil = 0;
+		while (!sc->sc_gerbil) {
+			if (sc->dead)		/* Race #1, b */
+				return EGONE;
+			cv_wait(&sc->cv, &sc->mtx);
+		}
 		mtx_unlock(&sc->mtx);
-		if (sc->dead)			/* Race #1, b */
-			return EGONE;
-		...
+		return (0);
+	default:
+		return (ENOTTY);
+	}
 }
 
 static void