From owner-freebsd-hackers Thu Apr 25 10:13:34 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by hub.freebsd.org (Postfix) with ESMTP id A096837B41D for ; Thu, 25 Apr 2002 10:13:24 -0700 (PDT) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.9.3/8.9.3) with ESMTP id NAA02625; Thu, 25 Apr 2002 13:13:24 -0400 (EDT) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.11.6/8.9.1) id g3PHCsn95014; Thu, 25 Apr 2002 13:12:54 -0400 (EDT) (envelope-from gallatin@cs.duke.edu) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15560.14613.989930.797068@grasshopper.cs.duke.edu> Date: Thu, 25 Apr 2002 13:12:53 -0400 (EDT) To: Kenneth Culver Cc: Subject: Re: pushal & ebp In-Reply-To: <20020425115941.C44727-100000@alpha.yumyumyum.org> References: <15560.4334.821343.177003@grasshopper.cs.duke.edu> <20020425115941.C44727-100000@alpha.yumyumyum.org> X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Kenneth Culver writes: > > I just looked at the NetBSD code & like linux, they use a macro which > > individually pushes the registers onto the stack rather than using > > pushal (which I assume is the same as what intel calls PUSHAD in their > > x86 instruction set ref. manual). > > > > NetBSD stopped using pushal in 1994 in rev 1.85 of their > > arch/i386/i386/locore.s in a commit helpfully documented > > "Don't use pusha and popa." > > > > Does anybody know why the other OSes push the registers individually, > > rather than using pushal? Could our using pushal be causing Kenneth's > > ebp to get lost, or is this just a red herring? > > > > Thanks, > > > > Drew > > > > > > > according to the intel docs, pushad (or what I'm assuming is pushal in our > case) pushes eax, ecx, edx, ebx then pushes some temporary value (the > original esp I think) then pushes ebp, esi, and edi: > > this is from the documentation for pushad > > IF OperandSize = 32 (* PUSHAD instruction *) > THEN > Temp (ESP); > Push(EAX); > Push(ECX); > Push(EDX); > Push(EBX); > Push(Temp); > Push(EBP); > Push(ESI); > Push(EDI); > > so could this be the problem? > > Ken I don't think so. The temp its pushing is the stack pointer. If you look at the layout of the trap frame, then you'll see tf_isp comes between tf_ebp & tf_ebx. I assume tf_isp is the stack pointer, so that should be OK.. Drew To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message