From owner-freebsd-current@FreeBSD.ORG Wed Feb 18 05:24:48 2009 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1C471065670; Wed, 18 Feb 2009 05:24:48 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 632558FC16; Wed, 18 Feb 2009 05:24:48 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id n1I5LiA7041225; Tue, 17 Feb 2009 22:21:45 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Tue, 17 Feb 2009 22:21:52 -0700 (MST) Message-Id: <20090217.222152.-109416210.imp@bsdimp.com> To: tinderbox@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20090217.203647.-1518647466.imp@bsdimp.com> References: <20090218023328.227617302F@freebsd-current.sentex.ca> <20090217.203647.-1518647466.imp@bsdimp.com> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: mips@FreeBSD.org, current@FreeBSD.org Subject: Re: [head tinderbox] failure on mips/mips X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2009 05:24:49 -0000 In message: <20090217.203647.-1518647466.imp@bsdimp.com> "M. Warner Losh" writes: : In message: <20090218023328.227617302F@freebsd-current.sentex.ca> : FreeBSD Tinderbox writes: : : /src/usr.sbin/bsnmpd/modules/snmp_mibII/../../../../contrib/bsnmp/snmp_mibII/mibII.c:1016: warning: cast increases required alignment of target type : : there's still 3 or 4 of these in the tree that I'm trying to track : back to root cause. A simple (void *) fixes the problem, but I want : to understand the issues before I slap that bad-boy in there... The first one is: case RTM_IFINFO: ifm = (struct if_msghdr *)rtm; mib_extract_addrs(ifm->ifm_addrs, (u_char *)(ifm + 1), addrs); if ((ifp = mib_find_if_sys(ifm->ifm_index)) == NULL) break; rtm is of type struct rt_msghdr. This has an alignment requirement of 4 on mips, at least on 32-bit mips (the biggest data element is a u_long). struct if_msghdr has an alignment requirement of 8, because time_t is int64_t on MIPS, which is 8-bytes in size. One way to fix this is to add __aligned(8) to struct rt_msghdr to compensate for this. Otherwise, if the time_t element is referenced in ifm_data we'll core dump. But that doesn't seem very portable and seems like a hack. Adding (void *) to "fix" the warning would be even worse... Anybody else have any ideas? Warner