From owner-svn-src-head@freebsd.org Sun Oct 25 01:20:06 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E235D43B354; Sun, 25 Oct 2020 01:20:06 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CJgBF71SFz4MJS; Sun, 25 Oct 2020 01:20:05 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f41.google.com with SMTP id h21so6305293iob.10; Sat, 24 Oct 2020 18:20:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2eAj9Xsn07VQSu4r6pMk+lqHI3ZiySdgQEepSiFXd8Y=; b=dG18DaTDOmFp9sCnJ4bAuEk4EVtYkLs1tURfZVBHUZ2rZAyMo3NhfvHQ9yIBiHxA3Z v/GSVD4TfbVkWesd3Ba+ETjw2xt3/SkNP9F+2xcLtjhdV4inXaUuJ3x+LcEfYtQLwdjM xURgpBNx7kNjeBGqf5V1RAhCE52JtswzXOcGT3/U44vW2/FRoDeJ/eQ4nM1aO0lO5Fvh sRXhzYknIpKy8mlPXIEIzqMpnuceRxkRbIb4rUbpm4AgwlXEN+pkKokDDdSrjXRhxU3U 0kCx0wPloYEQ2GWtcRfe1xwy9/vEzGh2V9LbnW/wc4lfREFL2J6AA8IQk1LkxpuBmjCU y+FA== X-Gm-Message-State: AOAM531kgZSvocUQ5Q4BS7DZ6GWqQvLP91Ho3iPyfNxp5hisj4DJDzif 0ewsPqc+n3xkoN5cBjwwkmKwaL4lSjLvy8JKaOE= X-Google-Smtp-Source: ABdhPJwS19s9Qjs+KkRxlov4wDKUNcYK+P+6G6fYGpzB+NkWqyetq4EuQkK6sPq/JvAQ0c2dtMhcchyjaWtVD/bcfoI= X-Received: by 2002:a5e:dc0b:: with SMTP id b11mr6721068iok.179.1603588804968; Sat, 24 Oct 2020 18:20:04 -0700 (PDT) MIME-Version: 1.0 References: <202010241023.09OANMcL075640@repo.freebsd.org> <20201024125206.GB38000@FreeBSD.org> <999a005e-1ef8-3c45-fb07-94a3b6ebce1b@selasky.org> <317231603546378@mail.yandex.ru> In-Reply-To: From: Ed Maste Date: Sat, 24 Oct 2020 21:19:52 -0400 Message-ID: Subject: Re: svn commit: r366993 - head/sys/net To: Warner Losh Cc: "Alexander V. Chernikov" , Hans Petter Selasky , Alexey Dokuchaev , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4CJgBF71SFz4MJS X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.166.41 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com X-Spamd-Result: default: False [-3.03 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[carpeddiem]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-0.96)[-0.960]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.995]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_IN_DNSWL_NONE(0.00)[209.85.166.41:from]; NEURAL_HAM_MEDIUM(-1.08)[-1.075]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.166.41:from]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Oct 2020 01:20:06 -0000 On Sat, 24 Oct 2020 at 11:27, Warner Losh wrote: > >> Given we already have nice .clang-format, that does most of the job, maybe it's worth considering looking into tweaking it further to fix this part? >> It would be nice if we could finally offload all formatting issues to the tool and focus on the actual code :-) > > It would be nice if it produced one of the style(9) acceptable formats without disrupting things already acceptable. That's been the big problem with the tweaks to date... some things are fixed, others break. It's getting a lot closer, though Upstream clang-format comes with a script that can integrate with git, adding a `git clang-format` command. It will apply formatting to modified lines, leaving unchanged ones alone.