From owner-cvs-all Tue Jan 11 7: 3:14 2000 Delivered-To: cvs-all@freebsd.org Received: from post.mail.nl.demon.net (post-11.mail.nl.demon.net [194.159.73.21]) by hub.freebsd.org (Postfix) with ESMTP id 425F214E95; Tue, 11 Jan 2000 07:03:06 -0800 (PST) (envelope-from marcel@scc.nl) Received: from [212.238.132.94] (helo=scones.sup.scc.nl) by post.mail.nl.demon.net with esmtp (Exim 2.12 #1) id 1282p6-0009gC-00; Tue, 11 Jan 2000 15:03:04 +0000 Received: from scc.nl (scones.sup.scc.nl [192.168.2.4]) by scones.sup.scc.nl (8.9.3/8.9.3) with ESMTP id QAA44159; Tue, 11 Jan 2000 16:03:03 +0100 (CET) (envelope-from marcel@scc.nl) Message-ID: <387B4627.D82F3E98@scc.nl> Date: Tue, 11 Jan 2000 16:03:03 +0100 From: Marcel Moolenaar Organization: SCC vof X-Mailer: Mozilla 4.7 [en] (X11; I; Linux 2.2.12 i386) X-Accept-Language: en MIME-Version: 1.0 To: "Rodney W. Grimes" Cc: Brian Feldman , cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libncurses Makefile src/gnu/lib/libdialog Makefile References: <200001111359.FAA24631@gndrsh.dnsmgr.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk "Rodney W. Grimes" wrote: > > > green 2000/01/11 04:37:58 PST > > The story is that these were added to beforeinstall improperly. In our > > beforeinstall, a full mtree has not been populated. Since the tree is > > not populated, we explode from missing directories on doc install. It > > should not be done in beforeinstall (includes) anyway. > > Given Marcel's work on the the buildworld process does it now make since > to fix the overloaded use of ``beforeinstall'' to be a few different > targets. Yes, please :-) > IMHO, we should at least split out all the includes into an includes: > target and stop calling beforeinstall to do this. (includes: would > be an internal target, the Makefile would just have INCLUDES=blah blah > and work something like MANx=, but has the problem of not all headers > go in a nice simple hierarchy like MAN, perhaps INCLUDEDIR= could be > used to solve this, perhaps not) We eventually can do the same for libraries. This also follows how we build world: includes first, then libraries and finally everything else. > If we get agreement I'll do the grunt work of the tree sweep to make it > happen (if Marcel will agree to review the patches :-)). Sure. Unfortunately I already killed my prototype patch, otherwise you wouldn't have to do anything. I had changed all those beforeinstall targets to include(s) targets before :-( It isn't even on freefall anymore or on any of my backups... damn... -- Marcel Moolenaar mailto:marcel@scc.nl SCC Internetworking & Databases http://www.scc.nl/ The FreeBSD project mailto:marcel@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message