Date: Fri, 25 Aug 2006 23:51:34 -0400 From: Alexander Kabaev <kabaev@gmail.com> To: Andrew Thompson <thompsa@freebsd.org> Cc: src-committers@freebsd.org, Peter Jeremy <peterjeremy@optushome.com.au>, cvs-all@freebsd.org, Steve Kargl <sgk@troutmask.apl.washington.edu>, cvs-src@freebsd.org, Guido van Rooij <guido@gvr.org> Subject: Re: cvs commit: src/contrib/ipfilter HISTORY Makefile bpf_filter.c ip_fil.c ipf.h ipmon.h ipt.h kmem.h mlfk_rule.c opts.h radix.c radix_ipf.h snoop.h src/contrib/ipfilter/BSD Makefile Makefile.ipsend kupgrade src/contrib/ipfilter/iplang iplang_l.l ... Message-ID: <20060825235134.1fecc2ff@kan.dnsalias.net> In-Reply-To: <20060826033029.GB80099@heff.fud.org.nz> References: <200608240737.k7O7bDMC085424@repoman.freebsd.org> <20060824092002.44b90594@kan.dnsalias.net> <20060824133628.GA54467@gvr.gvr.org> <20060824101606.414e8bf6@kan.dnsalias.net> <20060824205854.GA59856@gvr.gvr.org> <20060824184402.2ee29d79@kan.dnsalias.net> <20060826020854.GD16768@turion.vk2pj.dyndns.org> <20060826023120.GA74468@troutmask.apl.washington.edu> <20060826033029.GB80099@heff.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_pE0iKj=DyVlT+T+9MP6UgV_ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 26 Aug 2006 15:30:29 +1200 Andrew Thompson <thompsa@freebsd.org> wrote: > On Fri, Aug 25, 2006 at 07:31:20PM -0700, Steve Kargl wrote: > > On Sat, Aug 26, 2006 at 12:08:54PM +1000, Peter Jeremy wrote: > > > On Thu, 2006-Aug-24 18:44:02 -0400, Alexander Kabaev wrote: > > > >personally. The mistake you made just shows how important it is > > > >to do a buildworld _from freshly checked out sources_ after > > > >every major vendor import. > > >=20 > > > I'm not sure how doing this would have prevented the breakage. It > > > might have allowed Guido to notice the breakage more quickly. > >=20 > > > Doing a fresh checkout and a "make universe" > > > (since "make buildworld" is not always sufficient to catch > > > breakage) may not have been that much faster. > >=20 > > Huh? If Guido had done a "make buildworld" or "make universe" > > before he committed the source, then the problem would never have > > existed. >=20 > Thats not true in this case. The problem was that a new file hadnt > been cvs added, the file was sitting in his tree so it built > correctly, no amount of "make buildworld" or "make universe" would > have caught that, let it go. >=20 >=20 > Andrew For the last time, what part of _freshly checked out sources_ needs special explanation? Before that needs even more explanation, I'll even take it further: the test should be done on local repo copy first before 'real' one. Even without an extensive test above, a simple 'cvs update' before commit can be used to reveal all files that probably should either be added to CVS or removed. It isn't hard to spot all files prefixed with '?' in cvs output. The original breakage in -current was caused by a bug that simple compile test would have found. The compile test that clearly had not been tried. Between that and RELENG6 breakage I find it hard to believe that due attention has been paid doing ipfilter update work. --=20 Alexander Kabaev --Sig_pE0iKj=DyVlT+T+9MP6UgV_ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFE78VNQ6z1jMm+XZYRAi8YAJwPpNIsPGCvxi1Tj9ljRylU4cIdzgCgovPL gNTG2saNUGg4ptYtqMgqkxk= =HX8g -----END PGP SIGNATURE----- --Sig_pE0iKj=DyVlT+T+9MP6UgV_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060825235134.1fecc2ff>