From owner-freebsd-python@FreeBSD.ORG Sat Apr 12 03:10:44 2014 Return-Path: Delivered-To: python@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E8019719 for ; Sat, 12 Apr 2014 03:10:43 +0000 (UTC) Received: from mail-pa0-x22a.google.com (mail-pa0-x22a.google.com [IPv6:2607:f8b0:400e:c03::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B7E9D1E51 for ; Sat, 12 Apr 2014 03:10:43 +0000 (UTC) Received: by mail-pa0-f42.google.com with SMTP id fb1so6159418pad.15 for ; Fri, 11 Apr 2014 20:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:reply-to:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=JgwOOzrvL6dEJQ7DyY6OQlXgtuyF2A9NULooG6lXkyw=; b=lt2BToL6Koem/4lCXKm/bFeWrJs4Mc3Oijp9pgkNgkDSNL3tfWpopVvRpQRK/WDrBx QZFAx1ajU05jaScxn6x8lXvNAW7qiuvD0HywEBbWz1Yh6Obve6wmcE7fA+bX4mEEdlJY trobACvyUkKVkgkpl5XM3aBSoX5L5GcHFoY2kkuQNVb8clKwmmuEeBmhN1JBOnxckgo4 ZnLzwbA9CaBm9VMp5Uu4CGdQCJGyZ5KOkhm4ddlgYmXO1EWyyUAqLzYKxbCauz2wGTuO Y18RQm0sMQ8fjk2XJesodIlU7YNDv1mHRY+WNduY8NYArgnbcianme8Gz0RyrPR6WBS7 OMUg== X-Received: by 10.68.134.101 with SMTP id pj5mr31705549pbb.62.1397272243318; Fri, 11 Apr 2014 20:10:43 -0700 (PDT) Received: from [192.168.1.7] (ppp59-167-128-11.static.internode.on.net. [59.167.128.11]) by mx.google.com with ESMTPSA id vd8sm44170672pac.12.2014.04.11.20.10.40 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Apr 2014 20:10:42 -0700 (PDT) Message-ID: <5348AEA9.7030303@FreeBSD.org> Date: Sat, 12 Apr 2014 13:10:33 +1000 From: Kubilay Kocak User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Thunderbird/28.0 MIME-Version: 1.0 To: John Hein , python@freebsd.org Subject: Re: [patch] fix PYTHON_VERSION in py-setuptoolsXX References: <21320.42770.726441.667849@gromit.timing.com> In-Reply-To: <21320.42770.726441.667849@gromit.timing.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: koobs@FreeBSD.org List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Apr 2014 03:10:44 -0000 On 12/04/2014 12:38 PM, John Hein wrote: > The current settings in py-setuptools{27,32,33,34}/Makefile for > PYTHON_VERSION are wrong (X.Y instead of pythonX.Y), but sort of work > by chance rather than design. If it weren't for some unintended luck > from the way _PYTHON_VERSION is set and the .MAKEFLAGS line in > bsd.python.mk that forcibly sets > PYTHON_VERSION=python${_PYTHON_VERSION}, these ports would fail with > something like: > > Makefile error: bad value for PYTHON_VERSION: 3.3. > Legal values are: > python2.7 (default) > python3.1 > python3.2 > python3.3 > python3.4 > > > Please fix: > > Index: py-setuptools27/Makefile > =================================================================== > --- py-setuptools27/Makefile (revision 350922) > +++ py-setuptools27/Makefile (working copy) > @@ -3,7 +3,7 @@ > > PKGNAMESUFFIX= ${PYTHON_SUFFIX} > > -PYTHON_VERSION= 2.7 > +PYTHON_VERSION= python2.7 > > MASTERDIR= ${.CURDIR}/../py-setuptools > > Index: py-setuptools32/Makefile > =================================================================== > --- py-setuptools32/Makefile (revision 350922) > +++ py-setuptools32/Makefile (working copy) > @@ -3,7 +3,7 @@ > > PKGNAMESUFFIX= ${PYTHON_SUFFIX} > > -PYTHON_VERSION= 3.2 > +PYTHON_VERSION= python3.2 > > MASTERDIR= ${.CURDIR}/../py-setuptools > > Index: py-setuptools33/Makefile > =================================================================== > --- py-setuptools33/Makefile (revision 350922) > +++ py-setuptools33/Makefile (working copy) > @@ -3,7 +3,7 @@ > > PKGNAMESUFFIX= ${PYTHON_SUFFIX} > > -PYTHON_VERSION= 3.3 > +PYTHON_VERSION= python3.3 > > MASTERDIR= ${.CURDIR}/../py-setuptools > > Index: py-setuptools34/Makefile > =================================================================== > --- py-setuptools34/Makefile (revision 350922) > +++ py-setuptools34/Makefile (working copy) > @@ -3,7 +3,7 @@ > > PKGNAMESUFFIX= ${PYTHON_SUFFIX} > > -PYTHON_VERSION= 3.4 > +PYTHON_VERSION= python3.4 > > MASTERDIR= ${.CURDIR}/../py-setuptools > > > _______________________________________________ > freebsd-python@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-python > To unsubscribe, send any mail to "freebsd-python-unsubscribe@freebsd.org" > Thanks for the report John (and the one directly to me for bsd.python.mk) Can you also submit a PR so it can be tracked please. We use these for our quarterly reports among other things. This will also ensure you are notified when progress is made. ./koobs