Date: Mon, 10 Dec 2012 10:09:24 +0100 From: Pietro Cerutti <gahr@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r308484 - head/textproc/idnits Message-ID: <20121210090924.GA33683@gahrfit.gahr.ch> In-Reply-To: <20121210084822.GD34139@FreeBSD.org> References: <201212081626.qB8GQX0v075317@svn.freebsd.org> <20121210084822.GD34139@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2012-Dec-10, 08:48, Alexey Dokuchaev wrote: > On Sat, Dec 08, 2012 at 04:26:32PM +0000, Sunpoet Po-Chuan Hsieh wrote: > > New Revision: 308484 > > URL: http://svnweb.freebsd.org/changeset/ports/308484 > >=20 > > post-patch: > > - @${REINPLACE_CMD} -e '1 s|^#!/bin/bash|#!${LOCALBASE}/bin/bash|' \ > > - ${WRKSRC}/${PORTNAME} > > + @${REINPLACE_CMD} -e '1 s|^#!/bin/bash|#!${LOCALBASE}/bin/bash|' ${WR= KSRC}/${PORTNAME} >=20 > Do you mind backing this hunk out? Previous version was much better (mos= t of > us still use standard 80-char wide xterms). What about we *first* document somewhere that line width must be <=3D 80 (or 76, fwiw) and *then* try to enforce it on others' commits? Not that I'm against it in principle, but I don't feel comfortable with you making law out of your personal preference. --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp --BXVAT5kNtrzKuDFl Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDFpsMACgkQwMJqmJVx945kzgCbBcadM6jVYc774lt7k6Qp0CWx 5BYAoLYSxs+9D768syf+dBoTGchsGmzO =ySFl -----END PGP SIGNATURE----- --BXVAT5kNtrzKuDFl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121210090924.GA33683>