From owner-svn-ports-all@freebsd.org  Mon May 11 11:17:29 2020
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7369E2DE926;
 Mon, 11 May 2020 11:17:29 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 49LJLd2QjYz4QY5;
 Mon, 11 May 2020 11:17:29 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 478B83D48; Mon, 11 May 2020 11:17:29 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Hans Petter Selasky <hselasky@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r534893 - head/multimedia/webcamd
References: <202005110834.04B8YTMU056795@repo.freebsd.org>
Date: Mon, 11 May 2020 13:17:23 +0200
In-Reply-To: <202005110834.04B8YTMU056795@repo.freebsd.org> (Hans Petter
 Selasky's message of "Mon, 11 May 2020 08:34:29 +0000 (UTC)")
Message-ID: <tv0m-g1q4-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 May 2020 11:17:29 -0000

Hans Petter Selasky <hselasky@FreeBSD.org> writes:

> Author: hselasky
> Date: Mon May 11 08:34:28 2020
> New Revision: 534893
> URL: https://svnweb.freebsd.org/changeset/ports/534893
>
> Log:
>   Only set COMPAT32 option when building 64-bit platforms.
>   
>   PR:		245698
>   Approved by:	pi (implicit)
[...]
> -.if exists(/usr/lib32/libcuse.so)
> +.include <bsd.port.options.mk>
> +
> +.if ${ARCH} == amd64 || ${ARCH} == aarch64
>  OPTIONS_DEFAULT+=	COMPAT32
>  .endif

Looks pointless. Not only it misses other 64-bit archs like powerpc64 but
also doesn't address bug 245698 where user accidentally enabled COMPAT option.

Try the following instead

Index: multimedia/webcamd/Makefile
===================================================================
--- multimedia/webcamd/Makefile	(revision 534907)
+++ multimedia/webcamd/Makefile	(working copy)
@@ -20,15 +20,13 @@ USE_RC_SUBR=	webcamd
 SUB_FILES=	webcamd.conf
 
 OPTIONS_DEFINE=	COMPAT32 DEBUG HAL VT_CLIENT VT_SERVER DVB INPUT KEYBOARD MOUSE RADIO WEBCAM
-OPTIONS_DEFAULT=DVB HAL INPUT RADIO WEBCAM
+OPTIONS_DEFAULT=COMPAT32 DVB HAL INPUT RADIO WEBCAM
 
 COMPAT32_DESC=	Enable 32-bit compatibility support
 COMPAT32_MAKE_ARGS=	HAVE_COMPAT32="YES"
 
-.include <bsd.port.options.mk>
-
-.if ${ARCH} == amd64 || ${ARCH} == aarch64
-OPTIONS_DEFAULT+=	COMPAT32
+.if !exists(/usr/lib32/libcuse.so)
+OPTIONS_EXCLUDE+=	COMPAT32
 .endif
 
 HAL_DESC=	Build with HAL and DBUS support