From owner-freebsd-stable  Sun Dec  5 23: 8:45 1999
Delivered-To: freebsd-stable@freebsd.org
Received: from panzer.kdm.org (panzer.kdm.org [216.160.178.169])
	by hub.freebsd.org (Postfix) with ESMTP id 0030B14C0C
	for <stable@FreeBSD.ORG>; Sun,  5 Dec 1999 23:08:43 -0800 (PST)
	(envelope-from ken@panzer.kdm.org)
Received: (from ken@localhost)
	by panzer.kdm.org (8.9.3/8.9.1) id AAA01437
	for stable@FreeBSD.ORG; Mon, 6 Dec 1999 00:08:43 -0700 (MST)
	(envelope-from ken)
Message-Id: <199912060708.AAA01437@panzer.kdm.org>
Subject: small PCI change, need review
To: stable@FreeBSD.ORG
Date: Mon, 6 Dec 1999 00:08:43 -0700 (MST)
From: "Kenneth D. Merry" <ken@kdm.org>
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


Since I don't have a -stable test box, I'd appreciate it if someone could
try this patch.  (I've been running it on a number of older stable systems
for a few months.)

This should prevent the "garbage" output from 'pciconf -l' that some folks
may see if you've got PCI cards with no driver assigned.  (Peter Wemm
brought this fix into -current with the new-bus import in rev 1.95 of
pci.c.)

To try the patch, just apply it to pci.c, recompile, reinstall, reboot, and
then run 'pciconf -l' and make sure it looks okay.

Thanks,

Ken
-- 
Kenneth Merry
ken@kdm.org


==== //depot/FreeBSD-ken-stable/src/sys/pci/pci.c#1 - /a/ken/perforce/FreeBSD-ken-stable/src/sys/pci/pci.c ====
*** /tmp/tmp.1405.0	Mon Dec  6 00:03:50 1999
--- /a/ken/perforce/FreeBSD-ken-stable/src/sys/pci/pci.c	Mon Dec  6 00:03:06 1999
***************
*** 339,347 ****
  		if (devlist_entry == NULL)
  			return (NULL);
  
! 		cfg = &devlist_entry->cfg;
  
! 		bzero(cfg, sizeof *cfg);
  
  		cfg->bus		= probe->bus;
  		cfg->slot		= probe->slot;
--- 339,347 ----
  		if (devlist_entry == NULL)
  			return (NULL);
  
! 		bzero(devlist_entry, sizeof(*devlist_entry));
  
! 		cfg = &devlist_entry->cfg;
  
  		cfg->bus		= probe->bus;
  		cfg->slot		= probe->slot;


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message