From owner-svn-src-head@freebsd.org Tue Mar 21 20:18:42 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C529CD7C0D; Tue, 21 Mar 2017 20:18:42 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D0CF56AA; Tue, 21 Mar 2017 20:18:41 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1cqQEo-0001D3-D9; Tue, 21 Mar 2017 23:18:38 +0300 Date: Tue, 21 Mar 2017 23:18:38 +0300 From: Slawa Olhovchenkov To: Cy Schubert Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff , src-committers@freebsd.org, John Baldwin Subject: Re: svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt Message-ID: <20170321201838.GG86500@zxy.spb.ru> References: <20170321195202.GF86500@zxy.spb.ru> <201703212007.v2LK7gG8070455@slippy.cwsent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201703212007.v2LK7gG8070455@slippy.cwsent.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 20:18:42 -0000 On Tue, Mar 21, 2017 at 01:07:42PM -0700, Cy Schubert wrote: > In message <20170321195202.GF86500@zxy.spb.ru>, Slawa Olhovchenkov writes: > > On Tue, Mar 21, 2017 at 11:50:04AM -0700, Gleb Smirnoff wrote: > > > > > John, > > > > > > On Tue, Mar 21, 2017 at 10:40:34AM -0700, John Baldwin wrote: > > > J> First, this is a very good change and long overdue in divorcing the > > > J> user-facing structure for live system reporting vs the kernel structure. > > > J> > > > J> However, I realize you don't use info from netstat when debugging kernel > > > J> crash dumps, but other people _do_. It's ok if the kvm bits of netstat > > > J> require a matching kernel and thus require recompiling everytime the ABI > > > J> changes, but it is useful to have them. Please restore those. > > > > > > I have very much anticipated this comment from you, John. > > > > > > I would like to remind you, that we have had this very exact conversation > > > back when I removed kvm support from netstat/route.c. Let me search the > > > archives: > > > > > > https://lists.freebsd.org/pipermail/svn-src-head/2015-April/070480.html > > > > > > This conversation has had a continuation on IRC, which I don't archive. > > > > > > AFAIR, first I told that with all my involvement into networking stack, > > > I never ever had experienced a need to run route stats on a core. The > > > debugger were the only useful tool. And that opinion was seconded by > > > other network hackers. Then we discussed that a proper tool chould use > > > dynamic type parsing and not kvm(3). You said that future gdb has python > > > scripting and that would work fine. Meanwhile, you insisted that I restore > > > the functionality. I resisted to put kvm(3) back into netstat/route.c, and > > > instead I created a gdb script that prints exactly what 'nestat -anr -M cor > > e' > > > prints. And I committed the script just to satisfy your demand: > > > > > > tools/debugscripts/netstat-anr.gdb > > > > > > Can you please fairly answer, have you (or anyone else) ever used the > > > script during these 2 years? > > > > > > I believe, the inpcb/tcpcb printing from a core functionality has the > > > same level of real usefulness. I could create the same script for pcbs, > > > and I am afraid it is going to share fate of netstat-anr.gdb. > > > > How long run this script for core file w/ 40K TCP connections? > > Would it be possible to replace this script with new DTrace probes and a > DTrace script? DTrace probes in /etc/rc.d/savecore? Realy?