From owner-svn-src-all@FreeBSD.ORG Tue Mar 3 07:16:57 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F1FC1106566B; Tue, 3 Mar 2009 07:16:56 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from creme-brulee.marcuscom.com (marcuscom-pt.tunnel.tserv1.fmt.ipv6.he.net [IPv6:2001:470:1f00:ffff::1279]) by mx1.freebsd.org (Postfix) with ESMTP id 857DE8FC23; Tue, 3 Mar 2009 07:16:56 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from [IPv6:2001:470:1f00:2464::4] (shumai.marcuscom.com [IPv6:2001:470:1f00:2464::4]) by creme-brulee.marcuscom.com (8.14.3/8.14.3) with ESMTP id n237Imkv050278; Tue, 3 Mar 2009 02:18:48 -0500 (EST) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Alexander Motin In-Reply-To: <200903030639.n236dcYs000461@svn.freebsd.org> References: <200903030639.n236dcYs000461@svn.freebsd.org> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-5MWLXbR/UXM7HrEKzIDL" Organization: MarcusCom, Inc. Date: Tue, 03 Mar 2009 02:16:58 -0500 Message-Id: <1236064618.37252.169.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 FreeBSD GNOME Team Port X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on creme-brulee.marcuscom.com Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r189295 - head/sys/dev/ata/chipsets X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Mar 2009 07:16:57 -0000 --=-5MWLXbR/UXM7HrEKzIDL Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2009-03-03 at 06:39 +0000, Alexander Motin wrote: > Author: mav > Date: Tue Mar 3 06:39:38 2009 > New Revision: 189295 > URL: http://svn.freebsd.org/changeset/base/189295 >=20 > Log: > Set PortMultiplier port only for SATA2 channels, where it is applicable= . > Doing it on old SATA controllers like Promise PDC20375 SATA150 breaks > their operation. Thanks! My Tinderbox machine thanks you as well. Joe > =20 > Tested by: marcus on PDC20375 >=20 > Modified: > head/sys/dev/ata/chipsets/ata-promise.c >=20 > Modified: head/sys/dev/ata/chipsets/ata-promise.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/ata/chipsets/ata-promise.c Tue Mar 3 03:33:25 2009 (r18= 9294) > +++ head/sys/dev/ata/chipsets/ata-promise.c Tue Mar 3 06:39:38 2009 (r18= 9295) > @@ -690,8 +690,11 @@ ata_promise_mio_command(struct ata_reque > =20 > ATA_OUTL(ctlr->r_res2, (ch->unit + 1) << 2, 0x00000001); > =20 > - /* set portmultiplier port */ > - ATA_OUTB(ctlr->r_res2, 0x4e8 + (ch->unit << 8), atadev->unit & 0x0f)= ; > + if ((ctlr->chip->cfg2 =3D=3D PR_SATA2) || > + ((ctlr->chip->cfg2 =3D=3D PR_CMBO2) && (ch->unit < 2))) { > + /* set portmultiplier port */ > + ATA_OUTB(ctlr->r_res2, 0x4e8 + (ch->unit << 8), atadev->unit & 0x0f); > + } > =20 > /* XXX SOS add ATAPI commands support later */ > switch (request->u.ata.command) { > _______________________________________________ > svn-src-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >=20 --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-5MWLXbR/UXM7HrEKzIDL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkms2WkACgkQb2iPiv4Uz4eGlQCfWTtppeAPEPuKwLwCNL3XV2Pr FzYAn3bVb3EEB55dnoQHbkbtXJPvvGkc =Qhvk -----END PGP SIGNATURE----- --=-5MWLXbR/UXM7HrEKzIDL--