From owner-p4-projects@FreeBSD.ORG  Sat Jul 26 00:21:47 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C7E6B37B404; Sat, 26 Jul 2003 00:21:46 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6913537B401
	for <perforce@freebsd.org>; Sat, 26 Jul 2003 00:21:46 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0EDE943F3F
	for <perforce@freebsd.org>; Sat, 26 Jul 2003 00:21:46 -0700 (PDT)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6Q7Lj0U007781
	for <perforce@freebsd.org>; Sat, 26 Jul 2003 00:21:45 -0700 (PDT)
	(envelope-from marcel@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6Q7Ljoq007778
	for perforce@freebsd.org; Sat, 26 Jul 2003 00:21:45 -0700 (PDT)
Date: Sat, 26 Jul 2003 00:21:45 -0700 (PDT)
Message-Id: <200307260721.h6Q7Ljoq007778@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	marcel@freebsd.org using -f
From: Marcel Moolenaar <marcel@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 35027 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Jul 2003 07:21:48 -0000

http://perforce.freebsd.org/chv.cgi?CH=35027

Change 35027 by marcel@marcel_nfs on 2003/07/26 00:21:06

	Move uart_debug() to uart_core.c. It's useful enough to
	keep and the sloppy implementation is causing a build
	failure.

Affected files ...

.. //depot/projects/uart/dev/uart/uart_bus.h#8 edit
.. //depot/projects/uart/dev/uart/uart_core.c#8 edit

Differences ...

==== //depot/projects/uart/dev/uart/uart_bus.h#8 (text+ko) ====

@@ -30,7 +30,6 @@
 #define _DEV_UART_BUS_H_
 
 #include <sys/systm.h>
-#include <machine/stdarg.h>
 
 /* Drain and flush targets. */
 #define	UART_DRAIN_RECEIVER	0x0001
@@ -114,18 +113,7 @@
 int uart_tty_detach(struct uart_softc *);
 void uart_tty_intr(void *arg);
 
-static __inline void
-uart_debug(struct uart_softc *sc, const char *fmt, ...)
-{
-#if defined(UART_DEBUG) || 1
-	va_list ap;
-	va_start(ap, fmt);
-	if (sc != NULL)
-		device_print_prettyname(sc->sc_dev);
-	vprintf(fmt, ap);
-	va_end(ap);
-#endif
-}
+void uart_debug(struct uart_softc *, const char *, ...);
 
 /*
  * Receive buffer operations.

==== //depot/projects/uart/dev/uart/uart_core.c#8 (text+ko) ====

@@ -41,6 +41,7 @@
 #include <sys/termios.h>
 #include <sys/tty.h>
 #include <machine/resource.h>
+#include <machine/stdarg.h>
 
 #include <dev/uart/uart.h>
 #include <dev/uart/uart_bus.h>
@@ -70,6 +71,19 @@
 	.d_kqfilter = ttykqfilter,
 };
 
+void
+uart_debug(struct uart_softc *sc, const char *fmt, ...)
+{
+#if defined(UART_DEBUG) || 1
+	va_list ap;
+	va_start(ap, fmt);
+	if (sc != NULL)
+		device_print_prettyname(sc->sc_dev);
+	vprintf(fmt, ap);
+	va_end(ap);
+#endif
+}
+
 static void
 uart_tty_oproc(struct tty *tp)
 {