From owner-freebsd-arch@freebsd.org Fri Feb 17 21:20:27 2017 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E2D4CE3302 for ; Fri, 17 Feb 2017 21:20:27 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from smtp.vangyzen.net (hotblack.vangyzen.net [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f]) by mx1.freebsd.org (Postfix) with ESMTP id 58E101160 for ; Fri, 17 Feb 2017 21:20:27 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from ford.home.vangyzen.net (unknown [76.164.15.242]) by smtp.vangyzen.net (Postfix) with ESMTPSA id B637756486; Fri, 17 Feb 2017 15:20:26 -0600 (CST) Subject: Re: sem_timedwait3(..., ..., clockid_t) To: Ed Schouten References: <1d1cb3d6-a2d2-1a3e-5d20-51206524ffbe@FreeBSD.org> Cc: "freebsd-arch@freebsd.org" From: Eric van Gyzen Message-ID: Date: Fri, 17 Feb 2017 15:20:26 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 21:20:27 -0000 On 02/16/2017 00:47, Ed Schouten wrote: > Hi Eric, > > 2017-02-15 22:57 GMT+01:00 Eric van Gyzen : >> int sem_timedwait3_np(sem_t *sem, const struct timespec *abs_timeout, >> clockid_t clock_id); > > Could we please make the argument order a bit more consistent to > clock_nanosleep() (i.e., putting the clockid_t in front of the > timespec)? Sure. I had made them consistent with sem_timedwait, but your suggestion makes sense, especially since... > Should we also provide support for the TIMER_ABSTIME flag? That sounds useful. I would also need to add a parameter for returning the remaining time. How does this look? https://reviews.freebsd.org/D9656 I have not yet tested it, so don't spend time on a line-by-line review yet. Eric