From nobody Mon May 30 22:53:29 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 150241B618A6; Mon, 30 May 2022 22:53:33 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LBrL464Llz4hhl; Mon, 30 May 2022 22:53:32 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTP id vnYansWTbwtwGvoGLnrn2s; Mon, 30 May 2022 22:53:25 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id voGQnt7ejsF60voGRnu0s2; Mon, 30 May 2022 22:53:32 +0000 X-Authority-Analysis: v=2.4 cv=Z8n/oVdA c=1 sm=1 tr=0 ts=62954aec a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=oZkIemNP1mAA:10 a=JAf30KXuAAAA:8 a=YxBL1-UpAAAA:8 a=BWvPGDcYAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=9LMfYn6dYB8b_S205BUA:9 a=JOWeiY5itpwPQvuQ8dm/GawRuwE=:19 a=CjuIK1q_8ugA:10 a=GEL62FyrTCmHtEug2d3R:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=pxhY87DP9d2VeQe4joPk:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 2EB53413; Mon, 30 May 2022 15:53:30 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 1EB67197; Mon, 30 May 2022 15:53:29 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: David Wolfskill cc: Warner Losh , Cy Schubert , Kirk McKusick , src-committers , "" , dev-commits-src-main@freebsd.org, Toomas Soome Subject: Re: git: 076002f24d35 - main - Do comprehensive UFS/FFS superblock integrity checks when reading a superblock. In-reply-to: References: <202205271922.24RJMOJ2039923@gitrepo.freebsd.org> <20220530215552.EE5432C@slippy.cwsent.com> <20220530222402.E22C7114@slippy.cwsent.com> Comments: In-reply-to David Wolfskill message dated "Mon, 30 May 2022 15:41:43 -0700." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 30 May 2022 15:53:29 -0700 Message-Id: <20220530225330.1EB67197@slippy.cwsent.com> X-CMAE-Envelope: MS4xfI7uKnr7pokgl/mgqERMFz4lZXT/Rah3cMc/mbWPfrWNlUp25lcp+CEqCPi4ugQhhU1/dqLe9xeO4uv1yY+qo4OclS21S6MpkJgW2JcxOEoM3HtA0RCz OINSBbZ++Cj8jB7/ya5T3PbpFsX64qVQnac2Vck4DpFewhyVdrlIL3qFnwEikwHkApIQVnaIguI4pYEO49f0acKStWshuJhFLojOWWItfEf/kjabLzR8ttQX bJuZnjxSBZD/0r65Msk1cW14YnLR/Fo90Z1+Ossz/DNbNnLTqBLaqmuGvyS3quMhNurcNUWpdiHPI0FL7mmabnX4FDsABUCnsoLWBxqHYLuJebwxRNXTGiZk G1mDB6q/MKjNPL96k2OQ0L4+NEyRV5KrO7srSxGcTrIhdAqxojkFGT5JT7XrcH2yAtpywt+O X-Rspamd-Queue-Id: 4LBrL464Llz4hhl X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N In message , David Wolfskill writes: > > --3FHA/mTlTih/VEaV > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > On Mon, May 30, 2022 at 04:33:47PM -0600, Warner Losh wrote: > > On Mon, May 30, 2022 at 4:24 PM Cy Schubert > > wrote: > >=20 > > > Upgrading boot blocks didn't help either. > > > > > > It only happened on one of four machines. Likely because the other three > > > are AMD on Asus MBs while the problem machine is an Acer laptop running > > > Intel. > > In my case, the laptops are OK, but my build machine is affected. > > Info on it is anchored from > https://www.catwhisker.org/~david/FreeBSD/history/ (ref. machine > "freebeast"). > > > David Wolfskill reported the same: some are affected, others not. > > It's unclear why, exactly, but all the other details you gave track > > with the troubleshooting tsoome and I have been doing with him. > > I suppose it's a bit of a relief to know I'm not alone in this. :-} > > > The issue is inside of loader.efi or /boot/loader, not in the earlier > > boot blocks. > > .... > > I've ended up putting a gzipped dd image of the full file system from > /dev/ada0s4a up at https://www.catwhisker.org/~david/FreeBSD/head/loader/ I don't think this is a filesystem problem. All my / filesystems trace their ancestry back to the same machine decades ago. All were cloned at one point using dump | restore. All were newfs'd at some point to update from 8K blocks to 16K and eventually 32K blocksize, either using my USB rescue disk or a little bit of geom_mirror musical chairs. All four machines are consistently set up the same as each other (as much as possible considering different hardware and mirrors, except for the laptop which has a single disk). Another reason I don't think this a filesystem problem is that the root filesystem of the laptop was temporarily backed up while booted on the USB rescue disk, newfs performed on the slice, and restored. It is now a brand new UFS filesystem and this commit still had a problem. Also, reverting this commit resolved the problem. My guess is that a malloc() may be failing on the Acer/Intel laptop while succeeding on the Asus/AMD machines in my basement. -- Cheers, Cy Schubert or FreeBSD UNIX: Web: http://www.FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0