From owner-freebsd-stable Fri Jun 30 11:20: 1 2000 Delivered-To: freebsd-stable@freebsd.org Received: from freeway.dcfinc.com (cx74889-a.phnx3.az.home.com [24.1.193.157]) by hub.freebsd.org (Postfix) with ESMTP id 33D9F37C108 for ; Fri, 30 Jun 2000 11:19:58 -0700 (PDT) (envelope-from chad@freeway.dcfinc.com) Received: (from chad@localhost) by freeway.dcfinc.com (8.8.8/8.8.8) id LAA07889; Fri, 30 Jun 2000 11:19:56 -0700 (MST) (envelope-from chad) From: "Chad R. Larson" Message-Id: <200006301819.LAA07889@freeway.dcfinc.com> Subject: Re: dc19 fructration. In-Reply-To: <14684.42449.103888.380937@trooper.velocet.net> from David Gilbert at "Jun 30, 0 09:51:13 am" To: dgilbert@velocet.ca (David Gilbert) Date: Fri, 30 Jun 2000 11:19:55 -0700 (MST) Cc: freebsd-stable@FreeBSD.ORG Reply-To: chad@DCFinc.com X-Mailer: ELM [version 2.4ME+ PL40 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG As I recall, David Gilbert wrote: > I'm not 100% satisfied with the patch. I don't understand the > operation of SYSCTL_STRUCT() enough to make it allocatate things > dynamically --- it probably should. As evidenced by the printf(), it > knows the number of interfaces it's got right before it bzero()'s the > block to initialize it. > > The biggest insult was that BDG_MAX_PORTS was defined ... and used > elsewhere in the code, but that a static 16 entries was allocated in > the status struct (and not range checked anywhere). And just to preach to the converted, how long do you think it would have taken you to get that fixed if you were running Solaris? -crl -- Chad R. Larson (CRL15) 602-953-1392 Brother, can you paradigm? chad@dcfinc.com chad@larsons.org larson1@home.net DCF, Inc. - 14623 North 49th Place, Scottsdale, Arizona 85254-2207 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message