From owner-cvs-all@FreeBSD.ORG Mon Jun 11 20:41:06 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 81F9A16A400 for ; Mon, 11 Jun 2007 20:41:06 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id E053213C483 for ; Mon, 11 Jun 2007 20:41:05 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 93367 invoked from network); 11 Jun 2007 19:54:47 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 11 Jun 2007 19:54:47 -0000 Message-ID: <466DB362.8010902@freebsd.org> Date: Mon, 11 Jun 2007 22:41:06 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.12 (Windows/20070509) MIME-Version: 1.0 To: Jack Vogel References: <200706112008.l5BK8CQ7033543@repoman.freebsd.org> <466DACD6.4040606@errno.com> <2a41acea0706111330v6a39cf84o495f6acf62ba7ff7@mail.gmail.com> <2a41acea0706111333p5349993dg9315bfe8396f78a@mail.gmail.com> In-Reply-To: <2a41acea0706111333p5349993dg9315bfe8396f78a@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Sam Leffler , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/net if.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2007 20:41:06 -0000 Jack Vogel wrote: > On 6/11/07, Jack Vogel wrote: >> On 6/11/07, Sam Leffler wrote: >> > Andre Oppermann wrote: >> > > andre 2007-06-11 20:08:12 UTC >> > > >> > > FreeBSD src repository >> > > >> > > Modified files: >> > > sys/net if.h >> > > Log: >> > > Add IFCAP_LRO flag for drivers to announce their TCP Large >> Receive Offload >> > > capabilities. >> > > >> > > Revision Changes Path >> > > 1.108 +1 -0 src/sys/net/if.h >> > > http://cvsweb.FreeBSD.org/src/sys/net/if.h.diff?r1=1.107&r2=1.108 >> > > >> > > >> > There are many offload capabilities defined that are not well thought >> > out. In particular we do not distinguish between ipv4 and ipv6 for >> > things like cksum and tso so there's no way to disable individual >> > features. The ability to tweak LRO is clearly needed and clearly >> belong >> > as an ifnet capability but unilateraly deciding this is the wrong >> approach. >> > >> > Sam >> >> We do distinguish between TSO4 and TSO6, its just that all the pieces >> for 6 arent actually there yet, you are right about the cksum >> granularity, >> but I'm not convinced its needed. You might be right on the need to >> fine tune the functionality, but having a big ON/OFF doesnt seem a >> bad thing to me. > > Oh, one other useful tidbit, for Oplin when RSS is enabled you can't do > CKSUM anyway, they reuse bits. What is Oplin? -- Andre