Date: Tue, 1 Aug 2023 20:54:41 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: cf0a543f1f93 - main - cam: Log more error codes Message-ID: <202308012054.371Ksf59095555@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=cf0a543f1f93f95a1c452d710c67ba42a752a2b1 commit cf0a543f1f93f95a1c452d710c67ba42a752a2b1 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2023-08-01 20:51:10 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-08-01 20:51:54 +0000 cam: Log more error codes Log CAM_DEV_NOT_THERE status CCBs because they get dropped if a drive disappears and these requests timeout or are cancelled. It's useful to know the outstanding commands for failure analysis. Log CAM_NVME_STATUS_ERROR status CCBs to bring in NVMe errors (this will be more important in future commits that expand the information logged). Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D41168 --- sys/cam/cam_periph.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/cam/cam_periph.c b/sys/cam/cam_periph.c index 1ae994402211..c4c91a395894 100644 --- a/sys/cam/cam_periph.c +++ b/sys/cam/cam_periph.c @@ -1909,6 +1909,8 @@ cam_periph_error(union ccb *ccb, cam_flags camflags, case CAM_SCSI_STATUS_ERROR: case CAM_ATA_STATUS_ERROR: case CAM_SMP_STATUS_ERROR: + case CAM_DEV_NOT_THERE: + case CAM_NVME_STATUS_ERROR: devctl_err++; break; default:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202308012054.371Ksf59095555>