From owner-cvs-src@FreeBSD.ORG Sat May 31 13:37:58 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 117C537B405 for ; Sat, 31 May 2003 13:37:58 -0700 (PDT) Received: from falcon.midgard.homeip.net (h76n3fls20o913.telia.com [213.67.148.76]) by mx1.FreeBSD.org (Postfix) with SMTP id 52E7B43F85 for ; Sat, 31 May 2003 13:37:54 -0700 (PDT) (envelope-from ertr1013@student.uu.se) Received: (qmail 38323 invoked by uid 1001); 31 May 2003 20:37:52 -0000 Date: Sat, 31 May 2003 22:37:52 +0200 From: Erik Trulsson To: Poul-Henning Kamp Message-ID: <20030531203751.GA38298@falcon.midgard.homeip.net> Mail-Followup-To: Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200305312023.h4VKNkKq037126@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200305312023.h4VKNkKq037126@repoman.freebsd.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/isa clock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 May 2003 20:37:58 -0000 On Sat, May 31, 2003 at 01:23:46PM -0700, Poul-Henning Kamp wrote: > phk 2003/05/31 13:23:46 PDT > > FreeBSD src repository > > Modified files: > sys/i386/isa clock.c > Log: > Don't rely on boolean expression evaluating to 1 or 0 by default. Why not? In C the relational operators (including '==') *always* evaluate to 1 or 0. One can rely on that. I.e. this change doesn't really accomplish anything except make the expression somewhat more complicated. > > Found by: FlexeLint > > Revision Changes Path > 1.199 +1 -1 src/sys/i386/isa/clock.c > _______________________________________________ > cvs-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-all > To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" -- Erik Trulsson ertr1013@student.uu.se