From nobody Tue Feb 3 14:51:16 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f55yt5PJ9z6Pg5g; Tue, 03 Feb 2026 14:51:18 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f55yt1zW4z3vf4; Tue, 03 Feb 2026 14:51:18 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770130278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+chB/N2qS4yswu8IApvw4mthvha9ApyxHiBWCJniQyM=; b=JR3crviT5W9HxGnI/4P+6p16iyIEZLIjf6VdU2xLTH9pQaAFNBEC+6DWfOWoG4A1QTQB/P pdAq1DZey2NCxzZKd8l/O1sUWv8YksxcOrllzgxMhLiQsYnyl831NYpKsxulVW7J7wxaXv GIWTBGYxbYUJ52tAR/PyBNeVOqT6w54hENC7TAO8lg6MiprzWp8GNFcEO4LyRLWCN+ACpt lPw+d0dgkvqx0vvUyoM6y4LYZuVHBX+hR4q9quUiSdUKO+C87hCV/xcKsAshYVrTi3ODMa u0C6+QCKo3FAp9tm563XojpMdZQd5mAyhNjpyZUKHszj09Nf0Ycjwf/VFFSfuQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770130278; a=rsa-sha256; cv=none; b=KCdTRBUNMc+JaKuptiU1HtpqE4hYNLjdOEGtxpQ1in8uapYGOC+IzS1M/tpTeUtPD7mMbd scnpjNwBrnrrNc7nGZsFE+4pioR6wn8efNjsJLBLuinM5n0FlcrA4hF69a776itsN0aFRj ttxrWSjEbiVgqabwQvnhOUKWuGWyz2wBtKqWhncxikgkcJrm1r9QS9oBd1GlbbIZNsw0h/ JYPhPMxWzWN9yqlHfiOhce+HsyMV25483mcwYUUTtfzehIsMpKp+uFz+CicPobbjWqlL6/ FoiPxmay2AsWYFw2b1+pULyVx1YI0nlwiQYZ5Kkqnek6jy3tJNHaljhIYHcYQg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770130278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+chB/N2qS4yswu8IApvw4mthvha9ApyxHiBWCJniQyM=; b=LggO2tqzHPUQ0wYmpO4Idx4JvFYPzN5NgmrkWGdmKMqr0n66G/JB2zVMYHAeodjMM2BTAz nPP0sXt+Tpop/jCW7h8UcSVKMv8ND3sA/8Xcg12xbrVCppEzVSLIK2TRC5s3i6kzf34TJE CQMwkp/4kY5//BpJVoCzlej2rxn+Nb5VJwPEHF3spc1j+J7/IafW4V8vxxtCdO0yCSVIBZ 9mSdzcjIq8vspRfnrHEsuU+ZTZjbclzkveUUHJJeNsMZWXpRm9M71JkZwggGGc1nlo5ejK UuJPviPoYsoMZYuN1UcIhhGKUzgI+VXb3oq64YuQOYKUMC0K4vOvgFX+isfoug== Received: from ltc.des.dev (lfbn-nan-1-698-103.w86-236.abo.wanadoo.fr [86.236.35.103]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4f55yt0YSjz1C94; Tue, 03 Feb 2026 14:51:18 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id 5D7FA72B9E; Tue, 03 Feb 2026 15:51:16 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: ShengYi Hung Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 3e6e4e4a0d42 - main - hwpstate: add CPPC support for pstate driver on AMD In-Reply-To: <6958849c.4623e.7b53a822@gitrepo.freebsd.org> (ShengYi Hung's message of "Sat, 03 Jan 2026 02:53:16 +0000") References: <6958849c.4623e.7b53a822@gitrepo.freebsd.org> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Tue, 03 Feb 2026 15:51:16 +0100 Message-ID: <86ms1pdgnv.fsf@ltc.des.dev> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ShengYi Hung writes: > +static bool hwpstate_pkg_ctrl_enable =3D true; > +SYSCTL_BOOL(_machdep, OID_AUTO, hwpstate_pkg_ctrl, CTLFLAG_RDTUN, > + &hwpstate_pkg_ctrl_enable, 0, > + "Set 1 (default) to enable package-level control, 0 to disable"); This doesn't work. You are reusing the same OID already used by the Intel subdriver. The result is that whichever one happens to be first on the linker command line works and the other one doesn't. You have to either use a different OID for each subdriver or have both subdrivers share a single boolean. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org