Date: Sat, 5 Apr 2003 13:07:26 -0600 From: Mark Linimon <linimon@lonesome.com> To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports@FreeBSD.org Subject: Re: ports/44875: PYTHON_VERSION statement in make.conf adds a python dependency to all ports Message-ID: <200304051307.26815.linimon@lonesome.com> In-Reply-To: <200212080140.gB81e1kh088670@freefall.freebsd.org> References: <200212080140.gB81e1kh088670@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
(btw, this PR should probably be reassigned to portmgr, since
it does indeed involve a proposed change to bsd.port.mk).
The above proposed patch has one major problem: it assumes
that every port which sets PYTHON_VERSION also sets USE_PYTHON.
That is not currently the case. While the patch below would fix
the few cases where it currently isn't the case, incorporating both
the above and below patches would demand that this new constraint
be met (e.g., for new ports). I'm a little gun-shy about introducing
this constraint without discussion.
However, in fairness, only 4 ports in the entire tree (other than
lang/pythonXYZ themselves) ever set PYTHON_VERSION. The one
not patched below is zope itself, which got the constraint right in the
first place.
So, probably adding the constraint isn't too outrageous, but it
should be done with a heads-up or something.
--- databases/zpygresqlda/Makefile.dist Mon Mar 10 16:57:22 2003
+++ databases/zpygresqlda/Makefile Sat Apr 5 12:55:19 2003
@@ -19,6 +19,7 @@
LIB_DEPENDS= pq.3:${PORTSDIR}/${POSTGRESQL_PORT}
POSTGRESQL_PORT?= databases/postgresql7
+USE_PYTHON= yes
PYTHON_VERSION= python1.5
# You can change this in the environment
--- lang/ruby-python/Makefile.dist Fri Feb 21 07:16:16 2003
+++ lang/ruby-python/Makefile Sat Apr 5 12:52:34 2003
@@ -19,6 +19,7 @@
BUILD_DEPENDS= ${NONEXISTENT}:${PYTHON_PORTSDIR}:-DWITHOUT_THREADS
+USE_PYTHON= yes
PYTHON_VERSION?= python1.5
USE_RUBY= yes
--- mail/mahogany/Makefile.dist Fri Feb 21 07:16:21 2003
+++ mail/mahogany/Makefile Sat Apr 5 12:58:34 2003
@@ -21,6 +21,7 @@
BUILD_DEPENDS+= latex2html:${PORTSDIR}/textproc/latex2html
.endif
+USE_PYTHON= yes
PYTHON_VERSION= python1.5
USE_AUTOCONF_VER= 213
USE_GMAKE= yes
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200304051307.26815.linimon>