From owner-svn-src-head@FreeBSD.ORG Thu Feb 5 18:59:41 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E2B17106564A; Thu, 5 Feb 2009 18:59:41 +0000 (UTC) (envelope-from niclas.zeising@gmail.com) Received: from mxf2.bahnhof.se (mxf2.bahnhof.se [213.80.101.26]) by mx1.freebsd.org (Postfix) with ESMTP id 93E808FC1B; Thu, 5 Feb 2009 18:59:41 +0000 (UTC) (envelope-from niclas.zeising@gmail.com) Received: from localhost (mxf2.local [127.0.0.1]) by mxf2-reinject (Postfix) with ESMTP id BEB006BD12E; Thu, 5 Feb 2009 19:59:39 +0100 (CET) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MXF2) X-Spam-Score: 2.777 X-Spam-Level: ** X-Spam-Status: No, score=2.777 tagged_above=-99 required=5 tests=[DNS_FROM_RFC_POST=1.708, SPF_NEUTRAL=1.069] Received: from mxf2.bahnhof.se ([127.0.0.1]) by localhost (mxf2.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EGiPnwdxjUpY; Thu, 5 Feb 2009 19:59:38 +0100 (CET) Received: from [10.0.0.3] (h-85-24-219-30.NA.cust.bahnhof.se [85.24.219.30]) by mxf2.bahnhof.se (Postfix) with ESMTP id 8535A6BD102; Thu, 5 Feb 2009 19:59:38 +0100 (CET) Received: from 127.0.0.1 (AVG SMTP 8.0.233 [270.10.18/1935]); Thu, 05 Feb 2009 19:59:27 +0100 Message-ID: <498B370F.5090805@gmail.com> Date: Thu, 05 Feb 2009 19:59:27 +0100 From: Niclas Zeising User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: "M. Warner Losh" References: <200902051743.n15HhCMx033130@svn.freebsd.org> <498B2829.9000608@gmail.com> <20090205.113516.113804072.imp@bsdimp.com> In-Reply-To: <20090205.113516.113804072.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r188154 - head/sys/opencrypto X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Feb 2009 18:59:42 -0000 M. Warner Losh wrote: > In message: <498B2829.9000608@gmail.com> > Niclas Zeising writes: > : Warner Losh wrote: > : > Author: imp > : > Date: Thu Feb 5 17:43:12 2009 > : > New Revision: 188154 > : > URL: http://svn.freebsd.org/changeset/base/188154 > : > > : > Log: > : > Fix return type for detach routine (should be int) > : > Fix first parameter for identify routine (should be driver_t *) > : > > : > Modified: > : > head/sys/opencrypto/cryptosoft.c > : > > : > Modified: head/sys/opencrypto/cryptosoft.c > : > ============================================================================== > : > --- head/sys/opencrypto/cryptosoft.c Thu Feb 5 15:09:42 2009 (r188153) > : > +++ head/sys/opencrypto/cryptosoft.c Thu Feb 5 17:43:12 2009 (r188154) > : > @@ -986,7 +986,7 @@ done: > : > } > : > > : > static void > : > -swcr_identify(device_t *dev, device_t parent) > : > +swcr_identify(driver_t *drv, device_t parent) > : ^^^ > : > : Was this name change intentional? > > Yes. It 'dev' is typically used for 'device_t' types. However, by > changing this to drv, it shows it isn't a device_t, and also breaks > any code that used the old variable with a compiler error. > > Warner Ok, thanks for the education and sorry for the noise :) Regards Niclas > > : > { > : > /* NB: order 10 is so we get attached after h/w devices */ > : > if (device_find_child(parent, "cryptosoft", -1) == NULL && > : > @@ -1040,12 +1040,13 @@ swcr_attach(device_t dev) > : > return 0; > : > } > : > > : > -static void > : > +static int > : > swcr_detach(device_t dev) > : > { > : > crypto_unregister_all(swcr_id); > : > if (swcr_sessions != NULL) > : > free(swcr_sessions, M_CRYPTO_DATA); > : > + return 0; > : > } > : > > : > static device_method_t swcr_methods[] = { > : > : Regards! > : //Niclas > : > : >