From nobody Tue May 31 03:00:35 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E7D851B40F48; Tue, 31 May 2022 03:00:39 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LBxqB53HJz3hcN; Tue, 31 May 2022 03:00:38 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTP id vh61ns48SwtwGvs7TnsVau; Tue, 31 May 2022 03:00:31 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id vs7Ynh2keyz1uvs7ZnDYLM; Tue, 31 May 2022 03:00:38 +0000 X-Authority-Analysis: v=2.4 cv=J4G5USrS c=1 sm=1 tr=0 ts=629584d6 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=oZkIemNP1mAA:10 a=VxmjJ2MpAAAA:8 a=JAf30KXuAAAA:8 a=BWvPGDcYAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=Ia2FrnPiq9QLlT9xsuwA:9 a=JOWeiY5itpwPQvuQ8dm/GawRuwE=:19 a=CjuIK1q_8ugA:10 a=HUnkHirC5gcA:10 a=7gXAzLPJhVmCkEl4_tsf:22 a=GEL62FyrTCmHtEug2d3R:22 a=pxhY87DP9d2VeQe4joPk:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id E0BEE49E; Mon, 30 May 2022 20:00:35 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 78391185; Mon, 30 May 2022 20:00:35 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Cy Schubert cc: David Wolfskill , Warner Losh , Kirk McKusick , src-committers , "" , dev-commits-src-main@freebsd.org, Toomas Soome Subject: Re: git: 076002f24d35 - main - Do comprehensive UFS/FFS superblock integrity checks when reading a superblock. In-reply-to: <20220530231819.26E34CE@slippy.cwsent.com> References: <202205271922.24RJMOJ2039923@gitrepo.freebsd.org> <20220530215552.EE5432C@slippy.cwsent.com> <20220530222402.E22C7114@slippy.cwsent.com> <20220530225330.1EB67197@slippy.cwsent.com> <20220530231819.26E34CE@slippy.cwsent.com> Comments: In-reply-to Cy Schubert message dated "Mon, 30 May 2022 16:18:19 -0700." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 30 May 2022 20:00:35 -0700 Message-Id: <20220531030035.78391185@slippy.cwsent.com> X-CMAE-Envelope: MS4xfIrgk9pE6Z87HuA7UpH9OOQ487oGhZHcnd7jTTxWL1jwLsCDZOUX+sRfBBkU+3VqeCuR0ie7iRe3h3CeQvzw3SHH6RV9uZ9klI6LvkWDxCAw1bSPN8We XHb89rFCWvoRGARt6h3t9eu/w8iwSskpF+PtMLcUzdgQtMJKAsPkQsb/PAuiPAjgmJMD3UjHOmcJx8yDmQWgA8am4yJ3mth8ztDwmKruPP/y3X9lM3gNWNcJ 3wdXAzzIyjBVvyrR7ksqzKAhJEhkHBGovNfe/k2XLLq6C1KG9IR3AMMf6yVuQtQjPfBARWkS7GmSlKi/DHPR1LFDsI8ii2rdu1JMpA5CF5yhhnzFLCzK+Fku Gr0lrvZI3FTyNU8v6SUtps0b9PaEdTF+TH5+gsVqBcDJqvptVUHMQs1INg3ipnD4ikipA96j X-Rspamd-Queue-Id: 4LBxqB53HJz3hcN X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 3.97.99.32) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [0.19 / 15.00]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[4]; RCVD_IN_DNSWL_MED(-0.20)[3.97.99.32:from]; RCPT_COUNT_SEVEN(0.00)[8]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; MIME_TRACE(0.00)[0:+]; RECEIVED_SPAMHAUS_PBL(0.00)[70.66.148.124:received]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_SPAM_SHORT(0.99)[0.988]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; AUTH_NA(1.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main,dev-commits-src-all]; R_SPF_NA(0.00)[no SPF record]; FREEMAIL_CC(0.00)[catwhisker.org,bsdimp.com,freebsd.org,me.com] X-ThisMailContainsUnwantedMimeParts: N In message <20220530231819.26E34CE@slippy.cwsent.com>, Cy Schubert writes: > In message , David Wolfskill writes: > > > > > > --fbDsVP+DlYRwzumm > > Content-Type: text/plain; charset=us-ascii > > Content-Disposition: inline > > Content-Transfer-Encoding: quoted-printable > > > > On Mon, May 30, 2022 at 03:53:29PM -0700, Cy Schubert wrote: > > > ... > > > I don't think this is a filesystem problem. All my / filesystems trace=20 > > > their ancestry back to the same machine decades ago. All were cloned at o > = > > ne=20 > > > point using dump | restore. All were newfs'd at some point to update from > = > > =20 > > > 8K blocks to 16K and eventually 32K blocksize, either using my USB rescue > = > > =20 > > > disk or a little bit of geom_mirror musical chairs. All four machines are > = > > =20 > > > consistently set up the same as each other (as much as possible consideri > = > > ng=20 > > > different hardware and mirrors, except for the laptop which has a single= > > =20 > > > disk). > > > > I'm not disagreeing with you. :-) > > > > Providing the FS image (to Toomas) was a diagnostic aid: using it, he > > was able to reproduce the issue in his test-scaffolding environment, and > > was having some "quality time with gdb" before he needed to do other > > things (probably involving sleep). > > Hmmm. How interesting. > > Even after having newfs'd the filesystem and restoring it using a kernel > and userland that did not have the commit in question I still had the > problem. The two malloc()s are ok. The problem could be filesystem related. -- Cheers, Cy Schubert or FreeBSD UNIX: Web: http://www.FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0