From owner-dev-commits-ports-all@freebsd.org Tue Jun 8 15:32:50 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E789C63994B; Tue, 8 Jun 2021 15:32:50 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FzvPt62Dfz3KyQ; Tue, 8 Jun 2021 15:32:50 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1623166370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LMgFBSSdNPfCNU80DtX6blapzzYfgKqcpfzHTLxYaLQ=; b=Rdgw9NttN5fg0B0x5xACZFDLTHWXFE8xfISiGU9rqu6TRtJCYByOxTbf1fed7phJ1D9GNl JCNm9qONHboImHNbF/IQNtDVd4E8y45/wpyNDNQRz1/+gwxb51+qCVi06GMEGkKtaw+zyJ vQ3Iam2fq1GxZ44xOKfNlb9Qkg7VwZ+q+mKNFsE60hbOGyNSZ1eNrtmtgdXr+76VStrKo/ XwGKX6hRv63Pdx/ZL6h1YNF0g0vd9dFKIfiSQhqTQEdB7PiPjaqUeOxqbpO60OD8bGw+Nu 6i1LlVZbStadsnTdSvxsGzZfWwsC2kFJM8KhQTMzz6wNXP+g+OyeEfZ0b+aUig== Received: by freefall.freebsd.org (Postfix, from userid 1033) id B6A38D3DF; Tue, 8 Jun 2021 15:32:50 +0000 (UTC) Date: Tue, 8 Jun 2021 15:32:50 +0000 From: Alexey Dokuchaev To: Gleb Popov <6yearold@gmail.com> Cc: ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: f31a4d9f43ab - main - editors/xed: the port had been updated and changed (+) Message-ID: References: <202106081109.158B9949075935@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1623166370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LMgFBSSdNPfCNU80DtX6blapzzYfgKqcpfzHTLxYaLQ=; b=ZbfWOklX8tQCkRQCyFy2/Ny1ut7NAev1LQkPv6DC6B/C+lN4rDNX0NUb9c2LncZaarJnNZ YjJ6woNwUyeNlC2dzj/7Y+YSkDQOUZSd6EBKAd8s/SJpKFy8llh43FygnCelq8/ineV3HZ cMPf9J1jnRKmtj2quY72YOhKCophHjmWiNDPuU43KMAXOilpHaXGBQy5kc4kPb9nN81Xgh dqUS3fzCcG8XQD/4XNbnvHLp1iBUHzBfCfyP9B6JRseBRIv+JCJ7TUh20VfI0qaRqaBC8Y FY+tARRTqzk9qBuUcz7r2/CBU4gD5nbBDkE/jWKfoVwQs3LyneFD6++S6GjGbg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1623166370; a=rsa-sha256; cv=none; b=Jhlq4u6zz9b3gDhQrk8zA1zNxqxyAezHta3cJTm7t8zTg5mssB3SZcHwnQgq3XuiAio37B cehKNSVaZgKL24C513X+gsqIISk7+XR0R2R8BslHstwH6URRmpZEKEPua0ODftLrAkf8Uv LkdBXthUxYC2NHQbl4aAQOX/WMNLnfenZ2vmuwhB3WE81CspHFktA4BCdagmaXiVFF/P31 H5IDs0bkdaK9MY1uGNHcR0rTujZRxUWUVwlfqevv9WFLH9ob7DBSsC6eAWkWY4sA6UJ7e1 lAUK4RZW98n/VkHZVQ/0zqR+7lCTOEc8svSCU/Gu5ttR5hBLnKg3nA11eZWT6Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2021 15:32:51 -0000 On Tue, Jun 08, 2021 at 03:00:06PM +0300, Gleb Popov wrote: > On Tue, Jun 8, 2021 at 2:41 PM Alexey Dokuchaev wrote: > > On Tue, Jun 08, 2021 at 02:22:26PM +0300, Gleb Popov wrote: > > > On Tue, Jun 8, 2021 at 2:09 PM Alexey Dokuchaev wrote: > > > > commit f31a4d9f43abb0e189bbc4a710268dc6a82c05a9 > > > > > > > > editors/xed: the port had been updated and changed (+) > > > > > > What does (+) mean in your notation? > > > > It means that the first line is not a real commit log and could be > > safely omitted (it does not carry any useful information) and that > > the real log follows below. > > Makes sense, although I'd put "Update to 3.0.0" into the first line and > list all other changes below. In this particular case it would be appropriate, but often update is not the most important part of the commit. For example, in 082ab5c87d31012c there is an update and a bugfix, but it's actually the bugfix that brings the most noticeable UX improvements. Since I prefer to make more rare, but more significant commits, "subject" model often does not quite suit this model and just gets in the way. ./danfe