From owner-freebsd-current@FreeBSD.ORG Fri Sep 8 12:37:16 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E439816A4E2 for ; Fri, 8 Sep 2006 12:37:16 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 85F0343D49 for ; Fri, 8 Sep 2006 12:37:15 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 73565 invoked from network); 8 Sep 2006 12:21:54 -0000 Received: from dotat.atdotat.at (HELO [62.48.0.47]) ([62.48.0.47]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 8 Sep 2006 12:21:54 -0000 Message-ID: <450163FA.5090908@freebsd.org> Date: Fri, 08 Sep 2006 14:37:14 +0200 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050217 MIME-Version: 1.0 To: Ian FREISLICH References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net , freebsd-current , Prafulla Deuskar , Jack Vogel Subject: Re: RFC: TSO patch for current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2006 12:37:17 -0000 Ian FREISLICH wrote: > Andre Oppermann wrote: > >>Jack Vogel wrote: >> >>>On 9/5/06, Andre Oppermann wrote: >>> >>>>>If you do the ifconfig changes there will need to be a small amount of >>>>>code added to em_ioctl() but it should be trivial. >>>>> >>>>>You want me to reissue a driver patch with changes for your code? >>>> >>>>Yes, please do so. I've got a dual-em card which I can test with myself. >>> >>>OK, attached new patch, this one even has the ioctl change so when >>>you get the ifconfig change in it will be ready. >> >>The TSO code is committed. There has been a slight change with the >>ifcapabilities to differentiate between TSO for IPv4 and IPv6 which >>can be set independently. >> >>The pseudo-header checksum is always provided in m_pkthdr.csum_data, >>you don't have to compute it yourself in the driver. >> >>TSO for IPv6 is not yet functional as it is missing the in6_pseudo() >>functionand some changes to ip6_output(). I have contacted one of our >>IPv6 gurus to develop the patches and get it fully functional as well. > > > Since this change, I get the following output from ifconfig: > em0: flags=8843 mtu 1500 > options=cb > ether 00:04:23:d4:74:46 > media: Ethernet autoselect (1000baseTX ) > status: active > > If I disable polling: > em0: flags=8843 mtu 1500 > options=8b > ether 00:04:23:d4:74:46 > media: Ethernet autoselect (1000baseTX ) > > I'm not sure if this hardware supports TSO or even if the em driver > part has been committed yet. This is a problem with the pintb() function in ifconfig.c which apparently can't deal with digits in the bit description text. I'm looking for a fix. -- Andre