From owner-svn-src-head@FreeBSD.ORG Thu Nov 19 22:57:16 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AC864106568D; Thu, 19 Nov 2009 22:57:16 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.26]) by mx1.freebsd.org (Postfix) with ESMTP id 1C20E8FC19; Thu, 19 Nov 2009 22:57:15 +0000 (UTC) Received: by qw-out-2122.google.com with SMTP id 9so623407qwb.7 for ; Thu, 19 Nov 2009 14:57:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=cyI5ynS2OEJQ9u5SGRMrxKsQWLeBSSXIX5q81GRwL8k=; b=NYIY/k0DFr1gqcQgNOEsu+Lz7UkSmykdZivUFPkxFJZU9wEOyov1o6/Fmmdz13ijxk bxJHZpukE7nACMfVcwobHvc+6axZoTTPpdkq0MR2KvZemw0VucZleKoig5jSbKJ8wggc eZOkDs+F28H82HrydJIvuwuEda7ZmNWF87azM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=PX9HNGq7nctdOv7wghWwJ0yLp2ldDJL5IkN3EXoRb/E3MuKI2v4nWQw6LuDXNW+jL9 a2I9MWjyNe/ukaUb8VPdrX+tcEtV+MAaRA+4QQCTIB8VFWyxVZDVPylHwkU5hwvQ/yDd thZViWdfSsoKHL8seYJy2YQ+8Fa6E5VV+X1TI= Received: by 10.224.96.202 with SMTP id i10mr413758qan.311.1258671435353; Thu, 19 Nov 2009 14:57:15 -0800 (PST) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id 20sm729646qyk.9.2009.11.19.14.57.12 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 19 Nov 2009 14:57:13 -0800 (PST) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Thu, 19 Nov 2009 14:56:44 -0800 From: Pyun YongHyeon Date: Thu, 19 Nov 2009 14:56:44 -0800 To: Alexey Dokuchaev Message-ID: <20091119225644.GU1262@michelle.cdnetworks.com> References: <200911192145.nAJLj6KD020454@svn.freebsd.org> <20091119224151.GA79179@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091119224151.GA79179@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Pyun YongHyeon Subject: Re: svn commit: r199552 - head/sys/dev/et X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2009 22:57:16 -0000 On Thu, Nov 19, 2009 at 10:41:52PM +0000, Alexey Dokuchaev wrote: > On Thu, Nov 19, 2009 at 09:45:06PM +0000, Pyun YongHyeon wrote: > > > > Modified: head/sys/dev/et/if_et.c > > ============================================================================== > > --- head/sys/dev/et/if_et.c Thu Nov 19 21:39:43 2009 (r199551) > > +++ head/sys/dev/et/if_et.c Thu Nov 19 21:45:06 2009 (r199552) > > @@ -76,6 +76,10 @@ MODULE_DEPEND(et, pci, 1, 1, 1); > > MODULE_DEPEND(et, ether, 1, 1, 1); > > MODULE_DEPEND(et, miibus, 1, 1, 1); > > > > +/* Tunables. */ > > +static int msi_disable = 0; > > +TUNABLE_INT("hw.re.msi_disable", &msi_disable); > ^^^^^ > Shouldn't it be "hw.et" instead? > Oops, right. > > + msic = pci_msi_count(dev); > > + if (bootverbose) > > + device_printf(dev, "MSI count : %d\n", msic); > > Is extra space before colon really necessary here? > Not needed here. Thanks for reviewing! > ./danfe