From owner-freebsd-current Fri May 22 02:59:52 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id CAA19778 for freebsd-current-outgoing; Fri, 22 May 1998 02:59:52 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from ns1.yes.no (ns1.yes.no [195.119.24.10]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA19756 for ; Fri, 22 May 1998 02:59:48 -0700 (PDT) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [195.204.143.218]) by ns1.yes.no (8.8.7/8.8.7) with ESMTP id JAA06421; Fri, 22 May 1998 09:59:36 GMT Received: (from eivind@localhost) by bitbox.follo.net (8.8.8/8.8.6) id LAA27196; Fri, 22 May 1998 11:59:34 +0200 (MET DST) Message-ID: <19980522115933.24770@follo.net> Date: Fri, 22 May 1998 11:59:33 +0200 From: Eivind Eklund To: Bruce Evans , current@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pci if_tl.c if_tlreg.h References: <199805220502.PAA03138@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.89.1i In-Reply-To: <199805220502.PAA03138@godzilla.zeta.org.au>; from Bruce Evans on Fri, May 22, 1998 at 03:02:51PM +1000 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, May 22, 1998 at 03:02:51PM +1000, Bruce Evans wrote: > >> > No, no, no. Create an osreldate.h file instead. Please? Using __FreeBSD__ > >> > doesn't work because it's tied to the compiler, not the source. > > No. Neither should be used. If we want anybody external to FreeBSD to develop drivers (and I know _I_ do, at least) then we need to provide such a mechanism. Presently they use the value of __FreeBSD__, which is even more unsatifactory than __FreeBSD_version. > >That was the change I installed and backed out so fast earlier today; > >it unfortunately didn't work. > > Fortunately :-). If you didn't want __FreeBSD_version moved to param.h, you had every chance to object when I sent the proposal to -current - it had a very clear subject ("__FreeBSD_version -> param.h", I think). Right now that change is active in the tree (as I had time to fix it today). > >> did. If this is really a step forward then I'd suggest that > >> a whole lot more needs changing if self-consistency is also your > >> goal (and I think it should be, especially where this kind of > >> stuff is concerned, since other driver writers will imitate it). > > It's a step backwards. We use cvs for version control here. We're talking external drivers. I'm in favour of removing all #ifdefs for versions/systems from the FreeBSD tree, as long as it can be done in an automated fashion before each new import (I'm not certain how well unifdef handles the task - I've not looked at it). Eivind. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message