From owner-freebsd-ports-bugs@FreeBSD.ORG  Wed Aug 21 02:00:02 2013
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 24E3DBBC
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Wed, 21 Aug 2013 02:00:02 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 125E42BF7
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Wed, 21 Aug 2013 02:00:02 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r7L201tk001771
 for <freebsd-ports-bugs@freefall.freebsd.org>; Wed, 21 Aug 2013 02:00:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r7L201Km001770;
 Wed, 21 Aug 2013 02:00:01 GMT (envelope-from gnats)
Date: Wed, 21 Aug 2013 02:00:01 GMT
Message-Id: <201308210200.r7L201Km001770@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
Cc: 
From: Derek Kulinski <takeda@takeda.tk>
Subject: Re: ports/181248: [PATCH] print/cups-base Disable INSTALLS_ICONS for
 non-X11
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: Derek Kulinski <takeda@takeda.tk>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Aug 2013 02:00:02 -0000

The following reply was made to PR ports/181248; it has been noted by GNATS.

From: Derek Kulinski <takeda@takeda.tk>
To: bug-followup@FreeBSD.org, john.marshall@riverwillow.com.au
Cc:  
Subject: Re: ports/181248: [PATCH] print/cups-base Disable INSTALLS_ICONS for non-X11
Date: Tue, 20 Aug 2013 18:42:31 -0700

 Thanks John, for the fix I noticed it when I tried to update cups and
 portmaster showed me a huge list of ports that it'll install.
 
 I too would like to have this patch included, though I'm wondering if
 there was a reason not moving INSTALLS_ICONS in XDG_OPEN block as
 follows: 
 
 .if !defined(CUPS_CLIENT) && !defined(CUPS_IMAGE) && ${PORT_OPTIONS:MXDG_OPEN}
 RUN_DEPENDS+=           xdg-open:${PORTSDIR}/devel/xdg-utils
 INSTALLS_ICONS=true
 .endif
 
 As I understand this the part which adds X11 dependency, and as I
 understand WITHOUT_X11 is a legacy option.
 It also possibly fixes what commit 324428 was trying to fix, which is
 to make sure that this variable should be only defined for the
 cups-base.
 
 Best regards,
 Derek