From owner-cvs-all Wed Feb 7 12:20:17 2001 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 55BBA37B4EC; Wed, 7 Feb 2001 12:19:53 -0800 (PST) Received: (from ken@localhost) by freefall.freebsd.org (8.11.1/8.11.1) id f17KJri11452; Wed, 7 Feb 2001 12:19:53 -0800 (PST) (envelope-from ken) Message-Id: <200102072019.f17KJri11452@freefall.freebsd.org> From: "Kenneth D. Merry" Date: Wed, 7 Feb 2001 12:19:53 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: ports/audio/tosha/files patch-aa X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG ken 2001/02/07 12:19:53 PST Added files: audio/tosha/files patch-aa Log: Fix a core dump when doing 'tosha -i'. (Maintainer timeout after about two months.) The problem is in resolve_extension(). strncpy() will only null-terminate the destination string if it has enough room, according to the given length. In this implementation, there will never be enough room to null-terminate the string, from what I can tell. So if the memory in 'tmpstr' contains non-nulls, you'll get a core-dump in the subsequent strcat(). To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message