From owner-svn-src-head@freebsd.org Sat Oct 20 20:49:24 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8D78FF5495 for ; Sat, 20 Oct 2018 20:49:24 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2CE3A881BF for ; Sat, 20 Oct 2018 20:49:24 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-ed1-x534.google.com with SMTP id z21-v6so34400550edb.11 for ; Sat, 20 Oct 2018 13:49:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oEsPgl18xXbXNtPZW79hWJt128phxuoBO6Wh/QcHdq8=; b=qDzGTlUf6+tEaacLLjdxlP4c32Pxf1AWA/5NgxaRUdRE3Jg77tIHSevtlgfv/XZ+/h C3i0K9kc6rt0i9U5ofoHCewApXGMxSPCbRgya30mcl46eHOtm1R6+ax88YIbvq7W8YMl 80HjCK8Jqm+FoMCW3auPl5RgDUi5VQWbmoQPEqSZ5BJn3G5cRN7D15bCjYPDO2eFhhcA qzfN1FZJt6YBD7pd8NMRxvsqJQvJOGsT4YL9eXdMj5U5zKyGFB1XA9Wgf2Oq2/btaOsQ APDk4f4T+NuEpQRlz30Qe0juFJVD6MUWztN9Y2BiRCDL+6LgXue+M17qq0McsM2gP5bR b+5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oEsPgl18xXbXNtPZW79hWJt128phxuoBO6Wh/QcHdq8=; b=qin/6M9Y56xsb4mhX6stFxXetGif3l+kg3Dahsv3QGJEwsZGbWSlsfNmHN64D3nqAf P6ZPs04n1gNytlUGgjEXy6T3waleYuAC4O3/efuOdgIC6X1KoRBtAoO+cl5l+2HRL8P6 VXB51JvZzU40zOeZA786sa2XEOp3XNevHP0SlD/f2cXrz81yi0An4or9ZfM3fUNFGYiZ 01k1OGETZTEgHE0vFWHQylBy1NJDSe0GzPXC1OlOWeOOdOOTdpXTgKVBfFHJbkEe//Jv ggp3A7qjJo7E6UfJx15IU5aJi12v3YuOALH1GJHTkmkbK8R2l+Ys1Ewf+u+giQPv+3Tl QU7g== X-Gm-Message-State: ABuFfog8vw9BwxKimVezcFImZCQoCyo4UC5P5+4vs7xFfnSML3HW9HU1 BLCOrYC+LTH802KfUYS9YpPmSq/VuzWhggq2n7kgnA== X-Google-Smtp-Source: ACcGV63V1oLyzeZOByArQutMGawFHXY4wRp4tQ4jktbCq8tpPtPYIdRaGmNP/0HXy4RaTjVXJHeTyKJRAZ1oSbH/dYQ= X-Received: by 2002:a50:90a6:: with SMTP id c35-v6mr9808052eda.31.1540068563023; Sat, 20 Oct 2018 13:49:23 -0700 (PDT) MIME-Version: 1.0 References: <201810201831.w9KIVbtN043921@repo.freebsd.org> In-Reply-To: From: Ed Schouten Date: Sat, 20 Oct 2018 22:48:57 +0200 Message-ID: Subject: Re: svn commit: r339468 - in head/sys: kern sys To: "Conrad E. Meyer" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2018 20:49:24 -0000 Op za 20 okt. 2018 om 21:59 schreef Conrad Meyer : > > Can kdb_active, tp == NULL and panicstr != NULL even occur in this > > case? tty_info() can only get called in non-degenerate cases, right? > > I think you are correct, but I did not want to investigate to confirm. > This was just the direct, conservative conversion of ttyprintf -> > putchar. The checks can *probably* be removed. If they can, then certain other parts of this change can be reverted as well (e.g., the addition of cnputsn). -- Ed Schouten