From owner-cvs-src@FreeBSD.ORG Wed Sep 14 19:36:35 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E6CC516A41F; Wed, 14 Sep 2005 19:36:35 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id D21B543D46; Wed, 14 Sep 2005 19:36:34 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Wed, 14 Sep 2005 15:52:13 -0400 From: John Baldwin To: Ruslan Ermilov Date: Wed, 14 Sep 2005 15:37:30 -0400 User-Agent: KMail/1.8 References: <200509141233.j8ECXN28053907@repoman.freebsd.org> In-Reply-To: <200509141233.j8ECXN28053907@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200509141537.31787.jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_rl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 19:36:36 -0000 On Wednesday 14 September 2005 08:33 am, Ruslan Ermilov wrote: > ru 2005-09-14 12:33:23 UTC > > FreeBSD src repository > > Modified files: > sys/pci if_rl.c > Log: > Fixed "Memory modified after free" panic in rl_detach() due > to rl_stop() accessing already freed "struct ifnet". > > Fixed LOR between rl mutex and some ACPI mutex in rl_detach(). Very close to the patch I had. :) Note that you can remove the 'attached' variable now since it is only used once and just use 'device_is_attached()' inline in the if-statement like other drivers. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org