Date: Sat, 13 Jan 2024 18:41:06 +0100 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Charlie Li <vishwin@freebsd.org> Cc: Gleb Popov <arrowd@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org>, Daniel Engberg <diizzy@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 25e6f68a6661 - main - textproc/libxml2: Update to 2.11.6 Message-ID: <6e4dca8719bcb044186a179e708a32a1@mail.infomaniak.com> In-Reply-To: <02ebab1b-a763-45e4-9380-0d82c83c22a4@freebsd.org> References: <202401121705.40CH5JhG014492@gitrepo.freebsd.org> <ZaIcEvYZ2Yq_jW9Z@FreeBSD.org> <CALH631=meexWeEvPY4dBsVviAEms9OfcmKTk-YHGfw4fHJCzSw@mail.gmail.com> <a228d839c5a29d9991b72f1e0664da04@mail.infomaniak.com> <02ebab1b-a763-45e4-9380-0d82c83c22a4@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--_=_swift_1705167666_1c7aecfa727f1d5b08d0577ff1d95a80_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-01-13T14:36:58.000+01:00, Charlie Li <vishwin@freebsd.org> wrote:= >=C2=A0Daniel=C2=A0Engberg=C2=A0wrote: >>=C2=A0=C2=A0On=C2=A02024-0= 1-13T09:02:35.000+01:00,=C2=A0Gleb=C2=A0Popov=C2=A0<arrowd@freebsd.org> >= >=C2=A0=C2=A0wrote: >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0On=C2=A0Sat,= =C2=A0Jan=C2=A013,=C2=A02024=C2=A0at=C2=A08:14=C2=A0AM=C2=A0Alexey=C2=A0Dok= uchaev >>=C2=A0=C2=A0<danfe@freebsd.org >>=C2=A0=C2=A0 >>=C2=A0=C2= =A0=C2=A0<danfe@freebsd.org>>=C2=A0wrote: >>=C2=A0=C2=A0 >>=C2=A0=C2= =A0=C2=A0Wait,=C2=A0what?=C2=A0You've=C2=A0just=C2=A0removed=C2=A0the=C2= =A0comment=C2=A0which=C2=A0tells=C2=A0to=C2=A0NOT >>=C2=A0=C2=A0 >>= =C2=A0=C2=A0=C2=A0use=C2=A0the >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0dread= ed=C2=A0CMake=C2=A0and=C2=A0made=C2=A0the=C2=A0switch=C2=A0without=C2=A0log= ging=C2=A0any=C2=A0rationale? >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0CMake= >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0in=C2=A0such=C2=A0low-sitting=C2= =A0in=C2=A0dependency=C2=A0tree=C2=A0port=C2=A0is=C2=A0a=C2=A0PITA=C2=A0for= =C2=A0many >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0people, >>=C2=A0=C2= =A0 >>=C2=A0=C2=A0=C2=A0please=C2=A0don't=C2=A0push=C2=A0it=C2=A0down= =C2=A0our=C2=A0throats=C2=A0as=C2=A0you've=C2=A0been=C2=A0repeatedly >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0asked=C2=A0by >>=C2=A0=C2=A0 >>= =C2=A0=C2=A0=C2=A0other=C2=A0fellow=C2=A0developers. >>=C2=A0=C2=A0 >>= =C2=A0=C2=A0=C2=A0./danfe >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0I=C2=A0adm= it=C2=A0that=C2=A0there=C2=A0is=C2=A0no=C2=A0rationale=C2=A0for=C2=A0the= =C2=A0switch=C2=A0in=C2=A0the=C2=A0commit >>=C2=A0=C2=A0 >>=C2=A0=C2= =A0=C2=A0message.=C2=A0But=C2=A0at=C2=A0the=C2=A0same=C2=A0time,=C2=A0reduc= ing=C2=A0build=C2=A0times=C2=A0for=C2=A0Ports >>=C2=A0=C2=A0 >>=C2= =A0=C2=A0=C2=A0consumers=C2=A0has=C2=A0much=C2=A0lower=C2=A0priority=C2= =A0for=C2=A0us=C2=A0than=C2=A0actually=C2=A0updating >>=C2=A0=C2=A0 >>= =C2=A0=C2=A0=C2=A0software. >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Daniel= =C2=A0made=C2=A0sure=C2=A0that=C2=A0the=C2=A0switch=C2=A0doesn't=C2=A0cause= =C2=A0circular >>=C2=A0=C2=A0dependencies >>=C2=A0=C2=A0 >>=C2=A0= =C2=A0=C2=A0which=C2=A0was=C2=A0a=C2=A0problem=C2=A0before.=C2=A0Because= =C2=A0of=C2=A0that=C2=A0I=C2=A0approved=C2=A0the >>=C2=A0=C2=A0change, = >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0just=C2=A0for=C2=A0the=C2=A0sake=C2= =A0of=C2=A0the=C2=A0"updating"=C2=A0part. >>=C2=A0=C2=A0 >>=C2=A0=C2= =A0=C2=A0Daniel=C2=A0is=C2=A0not=C2=A0being=C2=A0paid=C2=A0for=C2=A0this= =C2=A0work,=C2=A0so=C2=A0if=C2=A0he's=C2=A0more >>=C2=A0=C2=A0comfortable= >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0with=C2=A0CMake=C2=A0(which=C2= =A0I=C2=A0wholeheartedly=C2=A0understand!)=C2=A0it=C2=A0is=C2=A0a >>= =C2=A0=C2=A0sufficient >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0rationale= =C2=A0for=C2=A0the=C2=A0switch.=C2=A0I=C2=A0believe=C2=A0no=C2=A0one=C2= =A0will=C2=A0be=C2=A0against=C2=A0if=C2=A0you >>=C2=A0=C2=A0 >>=C2= =A0=C2=A0=C2=A0prepare=C2=A0a=C2=A0patch=C2=A0that=C2=A0will=C2=A0switch= =C2=A0back=C2=A0to=C2=A0autotools=C2=A0and=C2=A0do=C2=A0the >>=C2=A0= =C2=A0same >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0amount=C2=A0of=C2=A0testi= ng=C2=A0(500+=C2=A0ports)=C2=A0that=C2=A0Daniel=C2=A0did. >=C2=A0 >= =C2=A0=C2=A0I=C2=A0will=C2=A0be=C2=A0doing=C2=A0exactly=C2=A0this=C2=A0for= =C2=A0the=C2=A02.12=C2=A0update.=C2=A0Already=C2=A0have=C2=A0a >=C2=A0WIP= . >=C2=A0 >>=C2=A0=C2=A0Hi, >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0I= =C2=A0want=C2=A0to=C2=A0add=C2=A0a=C2=A0few=C2=A0things=C2=A0that=C2=A0were= n't=C2=A0in=C2=A0the=C2=A0commit=C2=A0message=C2=A0but >>=C2=A0=C2=A0that= 's=C2=A0 >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0been=C2=A0discussed=C2= =A0and=C2=A0mentioned=C2=A0in=C2=A0the=C2=A0bugs=C2=A0report(s)=C2=A0and= =C2=A0elsewhere. >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Local=C2=A0patches= =C2=A0are=C2=A0a=C2=A0pain,=C2=A0no=C2=A0one=C2=A0has=C2=A0upstreamed=C2= =A0patches=C2=A0for=C2=A0years >>=C2=A0=C2=A0and=C2=A0 >>=C2=A0=C2= =A0 >>=C2=A0=C2=A0=C2=A0there's=C2=A0seemingly=C2=A0little=C2=A0to=C2= =A0no=C2=A0interest=C2=A0in=C2=A0doing=C2=A0so.=C2=A0For=C2=A0a=C2=A0single= >>=C2=A0=C2=A0 >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0committer=C2=A0tha= t=C2=A0might=C2=A0not=C2=A0be=C2=A0much=C2=A0of=C2=A0an=C2=A0issue=C2=A0but= =C2=A0it=C2=A0adds=C2=A0a >>=C2=A0=C2=A0overall=C2=A0 >>=C2=A0=C2=A0 = >>=C2=A0=C2=A0=C2=A0maintenance=C2=A0burden=C2=A0and=C2=A0that=C2=A0specifi= c=C2=A0maintainer/committer=C2=A0will >>=C2=A0=C2=A0not=C2=A0be=C2=A0 >= >=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0around=C2=A0forever.=C2=A0As=C2=A0a= =C2=A0community=C2=A0we've=C2=A0reported=C2=A0issues=C2=A0upstream, >>= =C2=A0=C2=A0issues=C2=A0 >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0have=C2= =A0been=C2=A0fixed=C2=A0and=C2=A0upstreamed=C2=A0patches.=C2=A0This=C2= =A0by=C2=A0far=C2=A0a=C2=A0better >>=C2=A0=C2=A0success=C2=A0 >>=C2= =A0=C2=A0 >>=C2=A0=C2=A0=C2=A0story=C2=A0than=C2=A0previously.=C2=A0It= =C2=A0isn't=C2=A0perfect=C2=A0but=C2=A0it=C2=A0is=C2=A0in=C2=A0better=C2= =A0shape >>=C2=A0=C2=A0than=C2=A0 >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2= =A0before=C2=A0and=C2=A0people=C2=A0are=C2=A0willing=C2=A0to=C2=A0contribut= e.=C2=A0There=C2=A0are=C2=A0more >>=C2=A0=C2=A0improvments=C2=A0 >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0upstream=C2=A0which=C2=A0be=C2=A0in= =C2=A0later=C2=A0releases=C2=A0too. >=C2=A0 >=C2=A0=C2=A0Until=C2=A0ups= tream=C2=A0specifically=C2=A0declares=C2=A0and=C2=A0recommends=C2=A0CMake= =C2=A0as=C2=A0ready >=C2=A0for=C2=A0 >=C2=A0 >=C2=A0Unix-like=C2= =A0systems=C2=A0in=C2=A0at=C2=A0least=C2=A0their=C2=A0documentation,=C2= =A0nothing=C2=A0else=C2=A0is >=C2=A0relevant. >=C2=A0 >=C2=A0--=C2= =A0 >=C2=A0 >=C2=A0Charlie=C2=A0Li >=C2=A0 >=C2=A0...nope,=C2=A0sti= ll=C2=A0don't=C2=A0have=C2=A0an=C2=A0exit=C2=A0line. Hi, Unless y= ou're planning to upstream patches you can already stop working on it. Th= is has been mention multiple times which you've so far ignored. There's l= ittle point in bumping before 2.13 is out which should be relatively soon= . Best regards, Daniel --_=_swift_1705167666_1c7aecfa727f1d5b08d0577ff1d95a80_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <div>On 2024-01-13T14:36:58.000+01:00, Charlie Li <vishwin@freebsd.org&g= t; wrote:<br></div><div class=3D"ik_mail_quote answerContentMessage"><block= quote class=3D"ws-ng-quote"><pre style=3D"white-space: normal;"><div>Daniel= Engberg wrote:<br></div><blockquote class=3D"ws-ng-quote"><div> On 2024-0= 1-13T09:02:35.000+01:00, Gleb Popov <<a href=3D"mailto:arrowd@freebsd.or= g" class=3D"defaultMailLink">arrowd@freebsd.org</a>> wrote:<br></div><di= v> <br></div><div> On Sat, Jan 13, 2024 at 8:14 AM Alexey Dokuchaev <= ;<a href=3D"mailto:danfe@freebsd.org" class=3D"defaultMailLink">danfe@freeb= sd.org</a><br></div><div> <<a href=3D"mailto:danfe@freebsd.org" clas= s=3D"defaultMailLink">danfe@freebsd.org</a>>> wrote:<br></div><div> <= br></div><div> <br></div><div> <br></div><div> Wait, what? You've j= ust removed the comment which tells to NOT<br></div><div> use the<b= r></div><div> dreaded CMake and made the switch without logging any= rationale?<br></div><div> CMake<br></div><div> in such low= -sitting in dependency tree port is a PITA for many<br></div><div> = people,<br></div><div> please don't push it down our throats as you= 've been repeatedly<br></div><div> asked by<br></div><div> = other fellow developers.<br></div><div> <br></div><div> ./danfe<br>= </div><div> <br></div><div> <br></div><div> I admit that there is no ra= tionale for the switch in the commit<br></div><div> message. But at the= same time, reducing build times for Ports<br></div><div> consumers has= much lower priority for us than actually updating<br></div><div> softw= are.<br></div><div> Daniel made sure that the switch doesn't cause circ= ular dependencies<br></div><div> which was a problem before. Because of= that I approved the change,<br></div><div> just for the sake of the "u= pdating" part.<br></div><div> <br></div><div> Daniel is not being paid = for this work, so if he's more comfortable<br></div><div> with CMake (w= hich I wholeheartedly understand!) it is a sufficient<br></div><div> ra= tionale for the switch. I believe no one will be against if you<br></div><d= iv> prepare a patch that will switch back to autotools and do the same<= br></div><div> amount of testing (500+ ports) that Daniel did.<br></div= ><div> <br></div></blockquote><div> I will be doing exactly this for the 2.= 12 update. Already have a WIP.<br></div><blockquote class=3D"ws-ng-quote"><= div> Hi,<br></div><div> <br></div><div> I want to add a few things that we= ren't in the commit message but that's <br></div><div> been discussed and m= entioned in the bugs report(s) and elsewhere.<br></div><div> <br></div><div= > Local patches are a pain, no one has upstreamed patches for years and <br= ></div><div> there's seemingly little to no interest in doing so. For a sin= gle <br></div><div> committer that might not be much of an issue but it add= s a overall <br></div><div> maintenance burden and that specific maintainer= /committer will not be <br></div><div> around forever. As a community we've= reported issues upstream, issues <br></div><div> have been fixed and upstr= eamed patches. This by far a better success <br></div><div> story than prev= iously. It isn't perfect but it is in better shape than <br></div><div> bef= ore and people are willing to contribute. There are more improvments <br></= div><div> upstream which be in later releases too.<br></div><div> <br></div= ></blockquote><div> Until upstream specifically declares and recommends CMa= ke as ready for <br></div><div>Unix-like systems in at least their document= ation, nothing else is relevant.<br></div><div><br></div><div>-- <br></div>= <div>Charlie Li<br></div><div>...nope, still don't have an exit line.<br></= div></pre></blockquote></div><div>Hi,<br></div><div><br></div><div>Unless y= ou're planning to upstream patches you can already stop working on it. This= has been mention multiple times which you've so far ignored. There's littl= e point in bumping before 2.13 is out which should be relatively soon.<br><= /div><div><br></div><div>Best regards,<br></div><div>Daniel<br></div><div><= br></div><div><br></div> --_=_swift_1705167666_1c7aecfa727f1d5b08d0577ff1d95a80_=_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6e4dca8719bcb044186a179e708a32a1>