From owner-freebsd-bugs@FreeBSD.ORG Fri Nov 14 07:10:17 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1CC2C16A4D0 for ; Fri, 14 Nov 2003 07:10:17 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1491043FB1 for ; Fri, 14 Nov 2003 07:10:13 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hAEFACFY047764 for ; Fri, 14 Nov 2003 07:10:12 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hAEFACcV047763; Fri, 14 Nov 2003 07:10:12 -0800 (PST) (envelope-from gnats) Resent-Date: Fri, 14 Nov 2003 07:10:12 -0800 (PST) Resent-Message-Id: <200311141510.hAEFACcV047763@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Daan Vreeken [PA4DAN]" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2AED216A4CE for ; Fri, 14 Nov 2003 07:08:26 -0800 (PST) Received: from Vitsch.net (b74143.upc-b.chello.nl [212.83.74.143]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B15143FB1 for ; Fri, 14 Nov 2003 07:08:24 -0800 (PST) (envelope-from root@Vitsch.net) Received: (from root@localhost) by Danovitsch.dnsq.org (8.12.3p2/8.11.3) id hADF2x3a089396; Thu, 13 Nov 2003 16:02:59 +0100 (CET) (envelope-from root) Message-Id: <200311131502.hADF2x3a089396@Danovitsch.dnsq.org> Date: Thu, 13 Nov 2003 16:02:59 +0100 (CET) From: "Daan Vreeken [PA4DAN]" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/59289: [PATH] ioctl METEORGBRIG in bktr_core.c forgets to add 128 to value X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: "Daan Vreeken \[PA4DAN\]" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Nov 2003 15:10:17 -0000 >Number: 59289 >Category: kern >Synopsis: [PATH] ioctl METEORGBRIG in bktr_core.c forgets to add 128 to value >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Nov 14 07:10:12 PST 2003 >Closed-Date: >Last-Modified: >Originator: Daan Vreeken [PA4DAN] >Release: FreeBSD 5.1-RELEASE i386 >Organization: >Environment: System: FreeBSD RaceBeest.Danovitsch.LAN 5.1-RELEASE FreeBSD 5.1-RELEASE #20: Mon Sep 1 16:39:56 CEST 2003 root@RaceBeest.Danovitsch.LAN:/home/src/sys/i386/compile/RaceBeest i386 >Description: In bktr_core.c the ioctl METEORSBRIG substracts 128 from the given value before storing it in the right brightness register, but METEORGBRIG doesn't add 128 to the value it gets out of the register. >How-To-Repeat: wantedvalue=129; ioctl(bktr,METEORSBRIG,&wantedvalue); ioctl(bktr,METEORGBRIG,&returnedvalue); if (returnedvalue!=wantedvalue) printf("EEK!\n"); >Fix: The following patch is agains -CURRENT and simply adds +128 to the value that's read from the register. --- diff begins here --- diff -ur sys-org/dev/bktr/bktr_core.c sys/dev/bktr/bktr_core.c --- sys-org/dev/bktr/bktr_core.c Sun Nov 9 10:17:21 2003 +++ sys/dev/bktr/bktr_core.c Thu Nov 13 15:38:57 2003 @@ -1511,7 +1511,7 @@ break; case METEORGBRIG: /* get brightness */ - *(u_char *)arg = INB(bktr, BKTR_BRIGHT); + *(u_char *)arg = INB(bktr, BKTR_BRIGHT) + 128; break; case METEORSCSAT: /* set chroma saturation */ --- diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: