From owner-freebsd-arch@FreeBSD.ORG  Thu May 21 09:39:26 2009
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9F4981065677
	for <arch@freebsd.org>; Thu, 21 May 2009 09:39:26 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 7AD118FC12
	for <arch@freebsd.org>; Thu, 21 May 2009 09:39:26 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [65.122.17.41])
	by cyrus.watson.org (Postfix) with ESMTPS id 17A4A46B65;
	Thu, 21 May 2009 05:39:26 -0400 (EDT)
Date: Thu, 21 May 2009 10:39:25 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Jeff Roberson <jroberson@jroberson.net>
In-Reply-To: <alpine.BSF.2.00.0905121430150.981@desktop>
Message-ID: <alpine.BSF.2.00.0905211038150.25537@fledge.watson.org>
References: <alpine.BSF.2.00.0905111720280.981@desktop>
	<20090512165949.GF58540@hoeg.nl>
	<alpine.BSF.2.00.0905121430150.981@desktop>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Ed Schouten <ed@80386.nl>, arch@freebsd.org
Subject: Re: lockless file descriptor lookup
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 May 2009 09:39:26 -0000


On Tue, 12 May 2009, Jeff Roberson wrote:

>> It's nice to see someone stepped up to implement this. Just out of 
>> curiosity, have you done any benchmarks to see how many percent of the time 
>> a thread needs more than one attempt to obtain a valid reference on a 
>> common workload?
>> 
>> Maybe it would be nice for diagnostic purposes to add two sysctls to obtain 
>> the amount of successful and unsuccessful attempts.
>
> I have had trouble triggering it at all in testing.  I'd prefer not to 
> commit the counters because they would re-introduce a global point of cache 
> contention unless we made them per-cpu.

Just as a general observation here: our recent experience with the sysctl 
counters for microtime(), et al, in the kernel strongly support this view: 
once the per-CPU allocator is available in the base kernel for 8.0, we should 
attempt to purge as many of these casually strewn counters in critical paths 
as we can.

Robert N M Watson
Computer Laboratory
University of Cambridge