From owner-freebsd-stable@FreeBSD.ORG Fri Jan 23 09:17:48 2009 Return-Path: Delivered-To: stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6835C10656CC; Fri, 23 Jan 2009 09:17:48 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.9.129]) by mx1.freebsd.org (Postfix) with ESMTP id 288588FC08; Fri, 23 Jan 2009 09:17:47 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 74B0873098; Fri, 23 Jan 2009 10:23:12 +0100 (CET) Date: Fri, 23 Jan 2009 10:23:12 +0100 From: Luigi Rizzo To: Oleg Bulyzhin Message-ID: <20090123092312.GC40642@onelab2.iet.unipi.it> References: <20090123081028.GA38763@onelab2.iet.unipi.it> <20090123085337.GB54838@lath.rinet.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090123085337.GB54838@lath.rinet.ru> User-Agent: Mutt/1.4.2.3i Cc: stable@FreeBSD.org, re@FreeBSD.org Subject: Re: backporting dummynet's q_time change ? (svn 184414) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2009 09:17:49 -0000 On Fri, Jan 23, 2009 at 11:53:37AM +0300, Oleg Bulyzhin wrote: > On Fri, Jan 23, 2009 at 09:10:28AM +0100, Luigi Rizzo wrote: > > in your logmessage for the q_time change in dummynet > > http://svn.freebsd.org/viewvc/base?view=revision&revision=184414 > > > > mentions an ABI change that would prevent backporting. > > > > However, as far as I can tell, the kernel side of the change is > > fully self-contained in the ip_dummynet module, and the only > > side effect on an out-of-sync userland (/sbin/ipfw) is that > > you would not be able to run "ipfw pipe show" -- but you > > can still configure ipfw rules and pipes and tables without > > problems. > > > > It seems to me that the change is sufficiently useful to deserve > > a MFC, and the side effects are negligible and do not prevent an > > upgrade with the usual sequence (installkernel-reboot-installworld) > > > > Any objection to an MFC ? > > > > cheers > > luigi > > > > _______________________________________________ > > freebsd-stable@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-stable > > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org" > > Have you seen this? > http://svn.freebsd.org/changeset/base/184506 this is also in RELENG_7 but i am not sure whether this workaround has any drawback e.g., when curr_time passes a 32-bit boundary there seems to be an incorrect setting of q->numbytes @@ -1382,7 +1383,7 @@ if (q->head != m) /* Flow was not idle, we are done. */ goto done; - if (q->q_time < curr_time) + if (q->q_time < (uint32_t)curr_time) q->numbytes = io_fast ? fs->pipe->bandwidth : 0; q->q_time = curr_time; cheers luigi