From owner-freebsd-multimedia@FreeBSD.ORG  Tue May  3 21:48:59 2005
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 556F516A4CE
	for <freebsd-multimedia@freebsd.org>;
	Tue,  3 May 2005 21:48:59 +0000 (GMT)
Received: from horse.iptelecom.net.ua (horse.iptelecom.net.ua [212.9.224.8])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2C7AD43D68
	for <freebsd-multimedia@freebsd.org>;
	Tue,  3 May 2005 21:48:58 +0000 (GMT)
	(envelope-from vkushnir@i.kiev.ua)
Received: from h80.242.159.dialup.iptcom.net ([213.159.242.80]:42745 "EHLO
	kushnir1.kiev.ua" ident: "SOCKFAULT1" whoson: "vkushnir")
	by horse.iptelecom.net.ua with ESMTP id S1219711AbVECVsy (INRCPT
	<rfc822;freebsd-multimedia@freebsd.org>);
	Wed, 4 May 2005 00:48:54 +0300
Received: from kushnir1.kiev.ua (kushnir1.kiev.ua [10.0.0.1])
	by kushnir1.kiev.ua (8.13.3/8.13.3) with ESMTP id j43Lmqux098383
	for <freebsd-multimedia@freebsd.org>;
	Wed, 4 May 2005 00:48:52 +0300 (EEST)
	(envelope-from vkushnir@i.kiev.ua)
Date: Wed, 4 May 2005 00:48:52 +0300 (EEST)
From: Vladimir Kushnir <vkushnir@i.kiev.ua>
X-X-Sender: vkushnir@kushnir1.kiev.ua
To: freebsd-multimedia@freebsd.org
In-Reply-To: <20050503070628.GF11140@puff.jakemsr.gom>
Message-ID: <20050504003425.A97449@kushnir1.kiev.ua>
References: <20050502043610.51034.qmail@exxodus.fedaykin.here>
 <4275B154.5070007@ahze.net> <20050503070628.GF11140@puff.jakemsr.gom>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Subject: Re: New ffmpeg CVS versions
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>,
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>,
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 May 2005 21:48:59 -0000



On Tue, 3 May 2005, Jacob Meuser wrote:

<snip>
>
> notes on grab_bsdbktr.c
>
<snip>
>  i think av_set_pts_info() needs to be moved up to before other
>  parameters in 's' are set in grab_read_header().

Actually, with av_set_pts_info() as it is grabbing doesn't work even in 
the present ffmpeg port. It should be
av_set_pts_info(st, 48, 1, 1000000);
not
av_set_pts_info(s1, 48, 1, 1000000);
(as av_set_pts_info() takes AVStream and not AVFormatContext). With this 
change ffmpeg grabs even without any move.
>
>  i'm pretty sure the av_free() in grab_read_close() can result in
>  double free errors, i.e. ffmpeg free()s the memory automagically.

Yep, it does.

Regards,
Vladimir