From nobody Tue Apr 26 19:51:09 2022 X-Original-To: office@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5FCCF1AAA34E for ; Tue, 26 Apr 2022 19:51:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KnsvL0jp5z3w6B for ; Tue, 26 Apr 2022 19:51:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EDDF215AA7 for ; Tue, 26 Apr 2022 19:51:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 23QJp9eL069679 for ; Tue, 26 Apr 2022 19:51:09 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 23QJp90m069678 for office@FreeBSD.org; Tue, 26 Apr 2022 19:51:09 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: office@FreeBSD.org Subject: maintainer-feedback requested: [Bug 263596] editors/libreoffice: make robust against __cxa_exception ABI changes Date: Tue, 26 Apr 2022 19:51:09 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: office@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Office applications on FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-office List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-office@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651002670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K/BbG6xprFxy1YyN7Q4D3ALoxdjjag+efK7CRRVzPlU=; b=LiM31vjESDBduZ38Ekyw333rjyiaI21ogEiFMjU9X+q3i1xdKSvte5UmXJdBCptmG10ye5 OA97EHtRQn6DQICshLkZqSo4V1+Krz5idULk2Wntc+8NZisJ1ijfAReiqPXplRSa/khwa2 PwWUMIcHHK2POX1l7njiYl7bsXCi1fPiz8H++26UwD8BagUpEYK8qaAG4yw5n1t8Hthi2H 7UJNjlyRdZiElMc8w0hxhpkGUmfCvBdjW/kvQywrL21r5uFMHLc7BM+UImXFS7f0LywQOY SWxegI3sTQH1VyKjbhatv9cDl3FjumXPAT1F+fauFqQsyS0kLqH0+7DdDbw3zQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651002670; a=rsa-sha256; cv=none; b=j6ZrMA+oypFDckPI0CRQT6rwhMqkJLWtzpO5+8t1FTCEP8Vz23i4TMu7hML1hQdjQhY62F ZiWEan6+eoO53N64HAGlv88DjUPD2zpUvTYqTw0mSyTYEAKVCuOoUz4V9JILdmBKAoORLN NXjzwggAgUiO2z+a/CyTf/Ycsk9rgkSEnRzlLT4GTQzTgW0wKukSn4qDdg6EA2JzOUccSa kw9kGDR/dXb+1YKXQdNbvripPlsr34v7RgxLyLvhaYs8F4QpZGhSK8CIkU8HmyCWofGrdu x02ujkYPsTpgw8gsqRtIIrPl7RWDlbnkgFIB8s5fwYiNVO6kWlAotlOqyMo33Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Bugzilla Automation has asked FreeBSD Office Team for maintainer-feedback: Bug 263596: editors/libreoffice: make robust against __cxa_exception ABI changes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263596 --- Description --- Patch libreoffice to replace __cxa_get_globals()->caughtExceptions, which is a pointer to the start of a struct __cxa_exception, with __cxa_current_primary_exception(), which is a pointer to the end. This allows struct __cxa_exception to be extended at the start as was recently done in FreeBSD main and stable/13 on 64-bit architectures. Recently on FreeBSD main and stable/13 __attribute__((__aligned__)) was added to struct _Unwind_Exception which changes its size on 32-bit architectures, and that of __cxa_exception as well. Patch libreoffice to detect this so packages built on 13.0 still work on 13.1. Change the LIB_DEPENDS on libunwind to a BUILD_DEPENDS because we only need unwind.h (for FreeBSD 13.0 and older where that header is hidden in /usr/include/c++/v1). I've build and run tested on i386 and I'll test on amd64 as well but it wou= ld be nice if others could test aarch64 and powerpc. Note that this patch dep= ends on the one in bug 263370.