From owner-cvs-src@FreeBSD.ORG Fri Mar 12 14:30:05 2004 Return-Path: <owner-cvs-src@FreeBSD.ORG> Delivered-To: cvs-src@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 931) id A88D716A4CF; Fri, 12 Mar 2004 14:30:05 -0800 (PST) Date: Fri, 12 Mar 2004 12:30:05 -1000 From: juli mallett <jmallett@FreeBSD.org> To: Kris Kennaway <kris@obsecurity.org> Message-ID: <20040312223005.GA8479@FreeBSD.org> References: <200403122106.i2CL6Kb6090102@repoman.freebsd.org> <20040312215450.GB46054@xor.obsecurity.org> <20040312220439.GC4588@ip.net.ua> <20040312222242.GA46557@xor.obsecurity.org> <20040312222434.GA46616@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040312222434.GA46616@xor.obsecurity.org> User-Agent: Mutt/1.4.1i X-Negacore: Yes X-Authentication-Warning: localhost: juli pwned teh intarweb X-Disclaimer: Opinions expressed about the deliciousness of eating brains are my own unless expressed by my employer. cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Ruslan Ermilov <ru@FreeBSD.org> cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_exec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/cvs-src> List-Post: <mailto:cvs-src@freebsd.org> List-Help: <mailto:cvs-src-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 12 Mar 2004 22:30:05 -0000 * Kris Kennaway <kris@obsecurity.org> [ Date: 2004-03-12 ] [ w.r.t. Re: cvs commit: src/sys/kern kern_exec.c ] > On Fri, Mar 12, 2004 at 02:22:42PM -0800, Kris Kennaway wrote: > > On Sat, Mar 13, 2004 at 12:04:39AM +0200, Ruslan Ermilov wrote: > > > On Fri, Mar 12, 2004 at 01:54:50PM -0800, Kris Kennaway wrote: > > > > On Fri, Mar 12, 2004 at 01:06:20PM -0800, Ruslan Ermilov wrote: > > > > > ru 2004/03/12 13:06:20 PST > > > > > > > > > > FreeBSD src repository > > > > > > > > > > Modified files: > > > > > sys/kern kern_exec.c > > > > > Log: > > > > > Do what the execve(2) manpage says and enforce what a Strictly > > > > > Conforming POSIX application should do by disallowing the argv > > > > > argument to be NULL. > > > > > > > > > > PR: kern/33738 > > > > > Submitted by: Marc Olzheim, Serge van den Boom > > > > > OK'ed by: nectar > > > > > > > > Is this likely to break any third party software (e.g. ports)? If so, > > > > please bump __FreeBSD_version. > > > > > > > It'll break only broken software, so I don't think the bump is in order. > > > > Well, that doesn't follow. When third party software suddenly stops > > running on FreeBSD, we need a way to predict in advance whether or not > > it will run on a given kernel -- whether the software is "broken" in > > an ideological sense or not. For example, we need to mark the port > > BROKEN on those versions of FreeBSD so the user doesn't waste their > > time worrying about or reporting a known problem. > > > > __FreeBSD_version bumps have negligible cost, so if we're both wrong > > and this has no effect, then no harm is done. > > It turns out this just happened for the ICC commit, so the only thing > that needs to be done is to document in the Porter's Handbook that the > new version also applies to your change. I'd figure that this isn't just ideologically broken. How much stuff works with a NULL argv? -- juli mallett. jmallett@freebsd.org. adrift in the pacific.