From owner-freebsd-java  Wed Mar 27 23:37: 3 2002
Delivered-To: freebsd-java@freebsd.org
Received: from wwweasel.geeksrus.net (wwweasel.geeksrus.net [64.8.210.226])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6D87837B41D; Wed, 27 Mar 2002 23:36:59 -0800 (PST)
Received: (from alane@localhost)
	by wwweasel.geeksrus.net (8.11.6/8.11.6) id g2S6KAV04380;
	Thu, 28 Mar 2002 01:20:10 -0500 (EST)
	(envelope-from alane)
Date: Thu, 28 Mar 2002 01:20:10 -0500 (EST)
Message-Id: <200203280620.g2S6KAV04380@wwweasel.geeksrus.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: java/jdk13
From: Alan Eldridge <ports@geeksrus.net>
Reply-To: Alan Eldridge <ports@geeksrus.net>
Cc: java@freebsd.org
X-send-pr-version: 3.113
X-GNATS-Notify: 
Sender: owner-freebsd-java@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-java.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-java>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-java>
X-Loop: FreeBSD.org


>Submitter-Id:	current-users
>Originator:	Alan Eldridge
>Organization:	Geeksrus.NET
>Confidential:	no 
>Synopsis:	java/jdk13
>Severity:	serious
>Priority:	medium
>Category:	ports
>Class:		sw-bug
>Release:	FreeBSD 4.5-STABLE i386
>Environment:
System: FreeBSD wwweasel.geeksrus.net 4.5-STABLE FreeBSD 4.5-STABLE #0: Mon Mar 11 00:59:22 EST 2002 root@wwweasel.geeksrus.net:/usr/obj/usr/src/sys/WWWEASEL i386

>Description:

When built as non-root, install by root leaves files owned by non-root
builder. This is a serious problem, as files in /usr/local should not be
owned by random users.

The following ports all have the same error in the Makefile:

java/gnu-regexp/Makefile
java/jakarta-oro/Makefile
java/jakarta-regexp/Makefile
java/jce-aba/Makefile
java/jdk-tutorial/Makefile
java/jdk/Makefile
java/jdk12-beta/Makefile
java/jdk13/Makefile
java/jre/Makefile
java/jsdk/Makefile
java/linux-ibm-jdk13/Makefile
java/linux-jdk/Makefile
java/linux-jdk13/Makefile
java/linux-jdk14/Makefile

To java@, how do you want the other 13 ports reported?  One big PR? 13
individual PRs? Do you want to extend this PR to conver the other 13?

>How-To-Repeat:

Build as non-root. Install as root. This *should* work correctly,
but does not.

>Fix:

Do *not* use tar|tar to install ports. Or do a massive "chown -Rh ..."
afterwards.

==8<====8<====8<====8<====8<====8<====8<====8<====8<====8<==
Index: java/jdk13/Makefile
===================================================================
RCS file: /home/alane/cvsup-ports/cvsroot/ports/java/jdk13/Makefile,v
retrieving revision 1.18
diff -u -3 -r1.18 Makefile
--- java/jdk13/Makefile	13 Mar 2002 15:06:15 -0000	1.18
+++ java/jdk13/Makefile	28 Mar 2002 05:57:13 -0000
@@ -126,11 +126,11 @@
 
 do-install:
 	${MKDIR} ${PREFIX}/jdk${JDK_VERSION}
-	(cd ${JDKIMAGEDIR} && ${BSD_TAR} -c -f - .) \
-		| (cd ${PREFIX}/jdk${JDK_VERSION} && ${BSD_TAR} --unlink -x -f -)
+	cd ${JDKIMAGEDIR} && find . \
+	  | cpio -pdmu -R ${LIBOWN}:${LIBGRP} ${PREFIX}/jdk${JDK_VERSION}
 .if !defined(NODEBUG)
-	(cd ${JDKIMAGEDIR_G} && ${BSD_TAR} -c -f - .) \
-		| (cd ${PREFIX}/jdk${JDK_VERSION} && ${BSD_TAR} --unlink -x -f -)
+	cd ${JDKIMAGEDIR_G} && find . \
+	  | cpio -pdmu -R ${LIBOWN}:${LIBGRP} ${PREFIX}/jdk${JDK_VERSION}
 .endif
 
 post-install:
==8<====8<====8<====8<====8<====8<====8<====8<====8<====8<==




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-java" in the body of the message