From owner-freebsd-stable@FreeBSD.ORG Sun Oct 21 08:54:01 2012 Return-Path: Delivered-To: freebsd-stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 37B1437A for ; Sun, 21 Oct 2012 08:54:01 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 773018FC0A for ; Sun, 21 Oct 2012 08:53:59 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA14981; Sun, 21 Oct 2012 11:53:54 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1TPrI9-000CXD-It; Sun, 21 Oct 2012 11:53:53 +0300 Message-ID: <5083B81F.2080909@FreeBSD.org> Date: Sun, 21 Oct 2012 11:53:51 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:16.0) Gecko/20121013 Thunderbird/16.0.1 MIME-Version: 1.0 To: Scot Hetzel Subject: Re: Problem reading vitals from Gigabyte H77-DH3H References: <1286515493.20121017131543@takeda.tk> <507F1761.1010202@FreeBSD.org> <20121017205147.GB36106@chinatsu.takeda.tk> <5081552F.2050303@FreeBSD.org> <771658188.20121019205010@takeda.tk> <508254AF.7040709@FreeBSD.org> <994545137.20121020010809@takeda.tk> <50826040.6010106@FreeBSD.org> <55342693.20121020103732@takeda.tk> <5082EEC8.2080307@FreeBSD.org> <198684285.20121020122034@takeda.tk> <5082FEA8.3050600@FreeBSD.org> <508304E6.6020202@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.4.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Derek Kulinski , freebsd-stable@FreeBSD.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Oct 2012 08:54:01 -0000 on 21/10/2012 10:11 Scot Hetzel said the following: > On Sat, Oct 20, 2012 at 3:09 PM, Andriy Gapon wrote: >> on 20/10/2012 22:42 Andriy Gapon said the following: >>> on 20/10/2012 22:20 Derek Kulinski said the following: >>>> I have three questions though: >>>> 1. The motherboard has 4 fan sockets (as far as I can tell), CPU_FAN, >>>> and SYS_FAN[1-3]. SYS_FAN1 currently is not connected. >>>> Seems like: >>>> fan0 -> CPU_FAN (did not try to disconnect it to check :) >>>> fan1 -> SYS_FAN1 >>>> fan2 -> SYS_FAN2 >>>> There is no entry for SYS_FAN3. I disconnected it temporarily but >>>> it did not seem to affect the output. Is it possible to get that >>>> information from the motherboard? >>> >>> The driver would have to be updated for that. >>> Unfortunately ITE does not provide public datasheets. >>> We could pick up some new bits from the Linux driver though. >>> http://lxr.linux.no/#linux+v3.6.2/drivers/hwmon/it87.c >> >> In fact, here is a completely untested patch: >> http://people.freebsd.org/~avg/it-fans-0x80.diff >> > > @@ -354,12 +372,15 @@ static void > it_refresh_sensor_data(struct it_softc *sc) > { > /* Refresh our stored data for every sensor */ > - it_generic_stemp(sc, &sc->sensors[12]); > - it_generic_svolt(sc, &sc->sensors[3]); > - if (sc->fan16bit) > + if (sc->fan16bit) { > it_16bit_fanrpm(sc, &sc->sensors[0]); > - else > + it_generic_svolt(sc, &sc->sensors[5]); > + it_generic_svolt(sc, &sc->sensors[14]); <- Looks to be a copy/paste bug ;-) Indeed. Should be "stemp" of course. Thank you! > + } else { > it_generic_fanrpm(sc, &sc->sensors[0]); > + it_generic_svolt(sc, &sc->sensors[3]); > + it_generic_stemp(sc, &sc->sensors[12]); > + } > } > -- Andriy Gapon