Date: Thu, 3 Mar 2022 10:47:58 GMT From: Alexey Dokuchaev <danfe@FreeBSD.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: git: 79404a91762e - main - audio/py-pyogg: adjust dependencies' type, prevent PATH poisoning Message-ID: <202203031047.223Alw8q099957@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by danfe: URL: https://cgit.FreeBSD.org/ports/commit/?id=79404a91762e2259c7ab153f4c583c73c8be291d commit 79404a91762e2259c7ab153f4c583c73c8be291d Author: Alexey Dokuchaev <danfe@FreeBSD.org> AuthorDate: 2022-03-03 10:47:02 +0000 Commit: Alexey Dokuchaev <danfe@FreeBSD.org> CommitDate: 2022-03-03 10:47:02 +0000 audio/py-pyogg: adjust dependencies' type, prevent PATH poisoning Contrary to Windows, we use colons to separate directories in the PATH environment variable; however, this code is still useless as it does not affect ctypes.util.find_library() search logic. Since libraries are opened during tun-time, LIB_DEPENDS should be actually specified as RUN_DEPENDS here (this would also hopefully prevent needless port revision bumps in the future). --- audio/py-pyogg/Makefile | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/audio/py-pyogg/Makefile b/audio/py-pyogg/Makefile index 5a370e5f033c..2d37ef405601 100644 --- a/audio/py-pyogg/Makefile +++ b/audio/py-pyogg/Makefile @@ -2,6 +2,7 @@ PORTNAME= PyOgg DISTVERSION= 0.6.14a1 +PORTREVISION= 1 CATEGORIES= audio python MASTER_SITES= CHEESESHOP PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} @@ -12,12 +13,17 @@ COMMENT= Xiph.org's Ogg Vorbis, Opus, and FLAC for Python LICENSE= UNLICENSE LICENSE_FILE= ${WRKSRC}/LICENSE -LIB_DEPENDS= libFLAC.so:audio/flac \ - libogg.so:audio/libogg \ - libopusfile.so:audio/opusfile \ - libvorbis.so:audio/libvorbis +RUN_DEPENDS= ${LOCALBASE}/lib/libFLAC.so:audio/flac \ + ${LOCALBASE}/lib/libogg.so:audio/libogg \ + ${LOCALBASE}/lib/libopusfile.so:audio/opusfile \ + ${LOCALBASE}/lib/libvorbis.so:audio/libvorbis USES= python USE_PYTHON= autoplist distutils +# Prevent needless (and wrong) PATH poisoning on Unix-like systems +post-patch: + @${REINPLACE_CMD} -e '48,/os\.environ\["PATH"\]/d' \ + ${WRKSRC}/pyogg/library_loader.py + .include <bsd.port.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202203031047.223Alw8q099957>