From owner-freebsd-bugs@FreeBSD.ORG  Mon Dec 17 17:31:16 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9DAEA16A494
	for <freebsd-bugs@FreeBSD.ORG>; Mon, 17 Dec 2007 17:31:16 +0000 (UTC)
	(envelope-from das@FreeBSD.ORG)
Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179])
	by mx1.freebsd.org (Postfix) with ESMTP id 68D9313C4D5
	for <freebsd-bugs@FreeBSD.ORG>; Mon, 17 Dec 2007 17:31:16 +0000 (UTC)
	(envelope-from das@FreeBSD.ORG)
Received: from VARK.MIT.EDU (localhost [127.0.0.1])
	by VARK.MIT.EDU (8.14.2/8.14.1) with ESMTP id lBHHUtog011893;
	Mon, 17 Dec 2007 12:30:55 -0500 (EST) (envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by VARK.MIT.EDU (8.14.2/8.14.1/Submit) id lBHHUtlx011892;
	Mon, 17 Dec 2007 12:30:55 -0500 (EST) (envelope-from das@FreeBSD.ORG)
Date: Mon, 17 Dec 2007 12:30:55 -0500
From: David Schultz <das@FreeBSD.ORG>
To: Dan Lukes <dan@obluda.cz>
Message-ID: <20071217173055.GC11621@VARK.MIT.EDU>
Mail-Followup-To: Dan Lukes <dan@obluda.cz>,
	Bruce Evans <brde@optusnet.com.au>, freebsd-bugs@FreeBSD.ORG
References: <200712170718.lBH7Iuoa026349@freefall.freebsd.org>
	<20071218033221.X31158@delplex.bde.org>
	<4766AE99.6040405@obluda.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4766AE99.6040405@obluda.cz>
Cc: freebsd-bugs@FreeBSD.ORG, Bruce Evans <brde@optusnet.com.au>
Subject: Re: bin/83347: [patch] improper handling of malloc failures within
	libc's vfprintf
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Dec 2007 17:31:16 -0000

On Mon, Dec 17, 2007, Dan Lukes wrote:
> Bruce Evans napsal/wrote, On 12/17/07 17:49:
> >I prefer following the NULL pointer to aborting.
> 
> 	Are you sure the *(NULL) raise exception on all platforms (at least 
> 	on supported platforms) ?

Quite sure.

> 	The professional applications shall never failed by the uncontrolled 
> way saying just "internal error" to user. It can be acceptable for 
> gurus, but it's not so nice for casual users.

It could be refactored to return ENOMEM, which is arguably
better. But crashing in a complicated way isn't any better than
crashing in a simple way.