Date: Mon, 30 Aug 2004 17:43:11 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: Peter Wemm <peter@wemm.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src UPDATING src/sys/sys param.h src/sys/net if.c if.h Message-ID: <20040831004311.GA29938@odin.ac.hmc.edu> In-Reply-To: <200408301729.22348.peter@wemm.org> References: <200408300629.i7U6TQ5C088279@repoman.freebsd.org> <16691.40287.478937.342838@grasshopper.cs.duke.edu> <20040830215323.GB24404@odin.ac.hmc.edu> <200408301729.22348.peter@wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--gKMricLos+KVdGMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 30, 2004 at 05:29:22PM -0700, Peter Wemm wrote: > On Monday 30 August 2004 02:53 pm, Brooks Davis wrote: > > On Mon, Aug 30, 2004 at 05:34:23PM -0400, Andrew Gallatin wrote: > > > Brooks Davis writes: > > > > I don't think so. The main offenders will be programs that walk > > > > the interface list via libkvm and programs that use struct > > > > if_data. ifconfig does neither. If you haven't recompiled a > > > > module, a non-working ifconfig might result if by some miracle > > > > you didn't get a panic on attach. > > > > > > ppc does not even build modules, so that's out. An older ifconfig > > > pukes, while a new one works, so some sort of kernel/userland ABI > > > must have changed in the last week. Has the data exported by > > > sysctl changed recently? > > > > I think I found it, at least partially. The issue is struct > > if_msghdr which is used by ifconfig. It contains a struct if_data.=20 > > It has grown by a struct timeval. The weird thing is that this > > shouldn't be a problem becuase if_msghdr has a length and my addition > > was to the end so ifconfig should be able to skip over it, but it > > doesn't seem to actually work. >=20 > It is broken on amd64 too, FWIW. If if_msghdr is the problem, it will be broken on all platforms and a rebuild of everything thing should fix it. I don't know why ifconfig is having a problem with the extension of if_msghdr. It shouldn't care since the format is unchanged other then the addition of a structure at the very end and the ifm_msglen member appears to be used correct to advance through the array passed by the sysctl. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --gKMricLos+KVdGMg Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBM8meXY6L6fI4GtQRAgUPAJoC8KAVL0cvcvUM4v+Ue9AWUyzgxACgwra6 RkGWJ0HB1ONoBhvL0chhzUM= =x1ex -----END PGP SIGNATURE----- --gKMricLos+KVdGMg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040831004311.GA29938>