From owner-freebsd-bugs  Thu Aug 22  2:10:14 2002
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1594D37B400
	for <freebsd-bugs@hub.freebsd.org>; Thu, 22 Aug 2002 02:10:05 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C4C0743E6A
	for <freebsd-bugs@hub.freebsd.org>; Thu, 22 Aug 2002 02:10:04 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g7M9A4JU052000
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 22 Aug 2002 02:10:04 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g7M9A4O3051998;
	Thu, 22 Aug 2002 02:10:04 -0700 (PDT)
Date: Thu, 22 Aug 2002 02:10:04 -0700 (PDT)
Message-Id: <200208220910.g7M9A4O3051998@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Magnus B{ckstr|m <b@etek.chalmers.se>
Subject: Re: kern/41881: ng_device was not MFCed for 2 months
Reply-To: Magnus B{ckstr|m <b@etek.chalmers.se>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR kern/41881; it has been noted by GNATS.

From: Magnus B{ckstr|m <b@etek.chalmers.se>
To: "Lev A. Serebryakov" <lev@serebryakov.spb.ru>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: kern/41881: ng_device was not MFCed for 2 months
Date: Thu, 22 Aug 2002 11:07:14 +0200 (CEST)

 On Thu, 22 Aug 2002, Lev A. Serebryakov wrote:
 > Subject: kern/41881: ng_device was not MFCed for 2 months
 > >Synopsis:       ng_device was not MFCed for 2 months
 
 >   CVS commit log for src/sys/netgraph/ng_device.c contains:
 >
 >   MFC after:	3 weeks
 >
 >   And it was 2 months ago.
 
 >    Please, MFC this ng type to STABLE.
 
 Isn't ng_device a work-in-progress still, rather than ready to be MFCd?
 When it first showed up I noted that A) it doesn't get built by default,
 and B) it has some problems:
 
 #include "ng_device.h"
 rather than
 #include <netgraph/ng_device.h>
 which makes it not compile when doing a make in sys/modules/netgraph/device,
 
 and the following passage (track what happens to `buffer'):
 
 	buffer = malloc(sizeof(char)*m->m_len, M_DEVBUF, M_NOWAIT | M_ZERO);
 	if(buffer == NULL) {
 		printf("%s(): ERROR: buffer malloc failed\n",__func__);
 		return(-1);
 	}
 
 	buffer = mtod(m,char *);
 
 	if( (connection->loc+m->m_len) < NGD_QUEUE_SIZE) {
 	        memcpy(connection->readq+connection->loc, buffer, m->m_len);
 		connection->loc += m->m_len;
 	} else
 		printf("%s(): queue full, first read out a bit\n",__func__);
 
 	free(buffer,M_DEVBUF);
 
 I assumed somebody was working on the file and thus didn't supply
 a patch PR; apparently though it is orphaned.
 
 bmb
 
 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message