Date: Sat, 15 Apr 2023 07:40:29 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Eugene Grosbein <eugen@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 3f3975ef8c26 - main - java/openjdk11: add new CUPS port option Message-ID: <ZDpU7ev7DKI/ImsH@FreeBSD.org> In-Reply-To: <202304150444.33F4ijSK040858@gitrepo.freebsd.org> References: <202304150444.33F4ijSK040858@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Apr 15, 2023 at 04:44:45AM +0000, Eugene Grosbein wrote:
> commit 3f3975ef8c2692cc0aedf26becd3ee6d2754fb81
>
> java/openjdk11: add new CUPS port option
>
> This change introduces new CUPS port option to java/openjdk11
> that defaults to ON to preserve current behaviour.
> With CUPS option turned OFF it skips build dependency on full cups:
> instead, it downloads and extracts its distfile and
> builds --with-cups-include pointing to extracted cups distfile.
> ...
> +CUPS_DISTFILES_OFF= OpenPrinting-cups-v${CUPS_INC_VER}_GH0.tar.gz:cups
> +
> +.if !${PORT_OPTIONS:MCUPS}
> +MASTER_SITES+= https://codeload.github.com/OpenPrinting/cups/tar.gz/v${CUPS_INC_VER}?dummy=/:cups
> +.endif
You should've probably depended on ${NONEXISTENT}:print/cups:patch, this way
you avoid having to keep two verions in sync and can benefit from any patches
that CUPS might require on FreeBSD, something like this:
BUILD_DEPENDS= ${NONEXISTENT}:print/cups:patch
_CUPS_WRKSRC= ${MAKE} -C ${PORTSDIR}/print/cups -V WRKSRC
CUPS_CONFIGURE_OFF= --with-cups-include=${_CUPS_WRKSRC:sh}/cups/cups.h
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZDpU7ev7DKI/ImsH>