From owner-cvs-all@FreeBSD.ORG  Mon Aug  2 21:51:12 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7906816A4CE; Mon,  2 Aug 2004 21:51:12 +0000 (GMT)
Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2E29E43D2F; Mon,  2 Aug 2004 21:51:12 +0000 (GMT)
	(envelope-from nate@root.org)
Received: from [10.0.0.34] (adsl-67-127-84-57.dsl.snfc21.pacbell.net
	[67.127.84.57])
	by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i72Lp82a015869;
	Mon, 2 Aug 2004 14:51:10 -0700
Message-ID: <410EB74B.7020206@root.org>
Date: Mon, 02 Aug 2004 14:51:07 -0700
From: Nate Lawson <nate@root.org>
User-Agent: Mozilla Thunderbird 0.7 (X11/20040702)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Murray <mark@grondar.org>
References: <200408021954.i72JsYD5028875@grimreaper.grondar.org>
In-Reply-To: <200408021954.i72JsYD5028875@grimreaper.grondar.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: Brooks Davis <brooks@one-eyed-alien.net>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: David O'Brien <obrien@FreeBSD.org>
Subject: Re: cvs commit: src/sys/modules Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Aug 2004 21:51:12 -0000

Mark Murray wrote:
> Brooks Davis writes:
> 
>>IMO this is a module system bug not a bug in any given module.  There's no
>>good reason for the system to succeed at loading a module that's already
>>there regardless of how it got there.  I don't understand the module
>>system well enough to know where the bug lies, but I believe the
>>DECLARE_MODULE statement provides more then enough information to avoid
>>duplicates.
> 
> I'm looking to see if MODULE_VERSION() may fix this.

The case where mem is compiled into the kernel and then an attempt is 
made to load it as a module needs to be detected by looking for an 
instance of the devclass.  See how acpi/legacy co-exist.  This is not 
just a problem with the same module being loaded multiple times.

-Nate