From owner-svn-src-all@freebsd.org Tue Jan 29 19:42:02 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8691B14C94BA; Tue, 29 Jan 2019 19:42:02 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 047F296A24; Tue, 29 Jan 2019 19:42:02 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x52d.google.com with SMTP id g189so9187779pgc.5; Tue, 29 Jan 2019 11:42:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=1+1GugW1X60E5vneE6bYddXyzY7pRPpyj22XJ3ZLupg=; b=I6zZhoGQAt+Kpgv94p2sp6zOp3wzVxjWRAl1TkLTJ8xrnAepGm5cs8v/9rv+Us1xfK 3EMpz1OU0r7Y9o73sc7TY15Da7KZpYB3U7A9dzrnHQt9BG1pj79EAf4M0oyA5ilPvY2c kLfWeelb9i+EjNnM3txR/Dw6+sI2+lZfrZZ7AFbaKiaV9N+P5CAK+7zTZY5ks61ED6Vq XudcNyhl/KOAr8OogB9NjEyG9ts9cwh6N66MUJ5AkcEGgKf2M9crkQtUpy0XYCG53208 qQF9b97i2T+8iNa37jyX3mucxxVKitnOkdgUbqKVOmz8k0h+HB3PYYMe7MboQDGRnnvH 7XJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=1+1GugW1X60E5vneE6bYddXyzY7pRPpyj22XJ3ZLupg=; b=KxEQD3fFywpiKaFl/Lq6VgznZSGbOidY9glpoN3xjG7bn5beV0+pUTaOC99wdENmK5 pVGMbii4U4Axsh7+R454lF5jalrAyNTwGuy7n743IV9emGwkwvCNo/91j/ERAaa0ipKY oxbrenayxTMPvaoQmFN2mAizDR0QoIJU0AyO6ieTGdIqeVp36cjRHnfVLPU8XEXQsvHg gkaPmYe1Wor9/X82midc0k6pRRwOIhwUD5UDNBZrVyDbDVbI4ptXxRie0w4twTYT8v08 IJyXsb1iQ94mGBY+XOqQ7j12JLnMh2agtO9ytz2TXjQzHyeGk8fplGXznpcBKcX9Jotj QzHQ== X-Gm-Message-State: AJcUukeQgX7JlCZe38qZ3JBZJlj4H+im2EzoQBQS+/WHZUK6rDzRIhfM R5K2HtR9mtUmRBya/pZKUCjOvxPI X-Google-Smtp-Source: ALg8bN46xGa/FyGFBuXMKdDvTCprEZe7646yjaiMmd2dFFR+cJZdtHwGfRmCJ9PFCYxMcaBa57YDog== X-Received: by 2002:a63:d104:: with SMTP id k4mr24326712pgg.227.1548790919509; Tue, 29 Jan 2019 11:41:59 -0800 (PST) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id x2sm49415488pfx.78.2019.01.29.11.41.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 11:41:58 -0800 (PST) From: Enji Cooper Message-Id: <89DD44B2-1A74-4FD4-9B66-26D924005892@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r343543 - head/sbin/bectl/tests Date: Tue, 29 Jan 2019 11:41:57 -0800 In-Reply-To: <1BE1B458-7AEA-412F-AD52-1E5554080422@gmail.com> Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Kyle Evans References: <201901290408.x0T48oJQ080243@repo.freebsd.org> <674E01AB-49C7-4B40-B2FD-6EB4AFEAB1FD@gmail.com> <5687EE07-74FB-4233-B51D-C8948641E8CB@gmail.com> <1BE1B458-7AEA-412F-AD52-1E5554080422@gmail.com> X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: 047F296A24 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.990,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2019 19:42:02 -0000 > On Jan 29, 2019, at 9:21 AM, Enji Cooper = wrote: =E2=80=A6 >> Right- this is the part that makes sense to me. =3D) The 'default2' = BE >> is clearly a leftover from a previous test, but it should've been >> unmounted in the process and the zpool cleaned up. >>=20 >> What's not clear is how the cleanup routine is failing; the `zpool = get >> health` shouldn't have any reason to fail (though I can't test it >> here, apparently =3D() and `zpool destroy -f` should've unmounted = this >> BE even if that hadn't happened throughout the course of the test, = but >> the failure remains (even if probably incorrectly fixed) following = the >> above commit. >>=20 >> Setting the zpool name globally with a suffix unique to this test >> would likely be a great idea -- I think there's something else going >> on as well, though. >=20 > My comment about the zpool name being defined locally to tests as = opposed is globally is probably what=E2=80=99s tripping you up. The = cleanup function is not run in the same shell context as the test. I submitted a proposed fix here: https://reviews.freebsd.org/D19024 = . After doing some more thinking, it dawned on me that these tests might = not be running in parallel, which (because they weren=E2=80=99t using = unique names) could be clashing with parallel executing tests. -Enji=